Closed
Conversation
danpetry
added
State: WIP
Contributor
|
I think it's better if we don't include the test suite in RIOT itself, but rather we download them as a package. |
Member
smlng
added
the
State: waiting for other PR
Contributor
big +1 one. Please don't simply copy the lua test code into the RIOT repo (as we speak about 15k lines of code here). You might want to add the tests either as a package on their own, or simply include them (maybe optional) to the lua pkg. |
- pexpect script - basic application in tests directory - lua test suite for v5.3.4
Contributor
|
Closed as it's easier to start from scratch. Will open new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This adds tests for the Lua pkg.
This PR will include a cut down version of the Lua test suite, written in Lua, and a basic assert test to test the "hello world" output in examples/lua, as a framework for tests for further additions such as API bindings.
Issues/PRs references
Depends on #9153, because without it, a lot of the tests are likely to fail.
Depends on #9282 to properly integrate Lua source code.