pkg/openthread: rework of FTD and MTD support by jia200x · Pull Request #9336 · RIOT-OS/RIOT

jia200x · 2018-06-12T15:53:36Z

Contribution description

This is a rework of #7149. The original PR by @biboc includes support for FTD, MTD and NCP.
This is (almost) and exact copy of his original work, but removes NCP support (see discussion)

It also sets the pkg version to the OpenThread Release Thread Reference 2017-07-16.

I had to modify a couple of stuff in order to make it work with the Release version, and I pushed those commits as fixup!. The initial commit was already reviewed in #7149.

#7149 should still be open, because it contains the NCP implementation that can be used after this gets merged.

Issues/PRs references

#7149
Fixes #10031

jia200x · 2018-06-12T15:54:38Z

Tested on IoTLAB and all multihop is working as expected. MTD is also working as it should.

aabadie

Thanks for moving this forward @jia200x!

The changes were indeed already mostly reviewed. I found one thing related to module dependencies. Not sure if it was already in the original PR.
I can test on iot-lab in a few days.

aabadie · 2018-06-12T18:33:45Z

Makefile.dep

  USEMODULE += gnrc_sock_udp
 endif

+ifneq (,$(filter openthread,$(USEPKG)))


I think the package dependencies could be added to a new pkg/openthread/Makefile.dep file instead. xtimer module could also be added as a dependency there.

aabadie · 2018-06-12T18:34:32Z

tests/openthread/Makefile


 USEMODULE += $(DRIVER)

+USEMODULE += xtimer


No need to add xtimer module as a dependency here if it's already a dependency of the openthread package.

yes, you are right. I will address the proposed comments

Still there.

jia200x · 2018-06-13T08:40:46Z

@aabadie done!

aabadie · 2018-06-13T12:06:36Z

tests/openthread/Makefile

+OPENTHREAD_PANID ?= 0xbeef
+OPENTHREAD_CHANNEL ?= 26
+
+CFLAGS += -DOPENTHREAD_PANID=${OPENTHREAD_PANID}


minor: use parenthesis instead of curly braces for accessing variables in Makefiles

aabadie · 2018-06-13T12:08:05Z

tests/openthread/main.c

    uint8_t res = ot_call_command("panid", NULL, (void*)&panid);
    printf("Current panid: 0x%x (res:%x)\n", panid, res);

-    openthread_uart_run();


why not keep the openthread shell ?

this is the OpenThread shell. The flow is OpenThread Core <-> Openthread CLI <-> UART

yes but here it's removed, so how can the OT shell be used ?

ah, I see what you mean. Now there's no "openthread_uart_run" simulator. It directly handles UART at interrupt level in the file platform_uart.c

Ok, got it now !

jia200x · 2018-06-13T12:10:47Z

@aabadie addressed

jia200x · 2018-06-13T12:44:49Z

@aabadie just addressed Murdock issues. Let's see how it goes

aabadie · 2018-06-13T13:20:06Z

@jia200x, seems like Murdock workers are missing automake.

jia200x · 2018-06-13T13:21:16Z

@aabadie I opened this PR some time ago in the riotdocker repo. It adds automake

Hyungsin · 2018-07-02T18:36:53Z

Any update here?

aabadie · 2018-07-03T07:00:26Z

I opened this PR some time ago in the riotdocker repo. It adds automake

I just merged it but now I think we have to wait for the new docker image to be deployed on Murdock workers.

aabadie · 2018-07-03T07:05:06Z

@jia200x, how about moving the openthread test application to the examples directory ?

jia200x · 2018-07-05T12:05:32Z

Back from holidays, sorry the delay.
It makes sense to me to move the test. I will do it.

jia200x · 2018-07-05T13:23:22Z

@aabadie just moved the examples folder. Do you know if the Murdock workers were updated?

jia200x · 2018-07-05T13:27:31Z

@aabadie there's an error with Murdock I'm not able to reproduce:

Building application "openthread" for "fox" with MCU "stm32f1".

Compile OpenThread for FTD device
$OPENTHREAD_ARGS is [--enable-cli-app=ftd --enable-application-coap]
make[1]: Nothing to be done for 'prepare'.
Compile OpenThread for FTD device
$OPENTHREAD_ARGS is [--enable-cli-app=ftd --enable-application-coap]
cd /tmp/dwq.0.9284869489919173/0d721c1ca21ff9c139e349583b111504/examples/openthread/bin/pkg/fox/openthread && PREFIX="/" ./bootstrap
./third_party/nlbuild-autotools/repo/scripts/bootstrap: 280: ./third_party/nlbuild-autotools/repo/scripts/bootstrap: --automake: not found
cd /tmp/dwq.0.9284869489919173/0d721c1ca21ff9c139e349583b111504/examples/openthread/bin/pkg/fox/openthread && CPP="arm-none-eabi-gcc -E" CC="arm-none-eabi-gcc" CXX="arm-none-eabi-g++"\
	OBJC="" OBJCXX="" AR="arm-none-eabi-ar" RANLIB="arm-none-eabi-ranlib" NM="" \
	STRIP="" \
	CPPFLAGS="-fdata-sections -ffunction-sections -Os -Wno-implicit-fallthrough -Wno-unused-parameter -mcpu=cortex-m3 -mlittle-endian -mthumb -mfloat-abi=soft -DOPENTHREAD_PROJECT_CORE_CONFIG_FILE='\"platform_config.h\"'" \
	CFLAGS="-fdata-sections -ffunction-sections -Os -Wno-implicit-fallthrough -Wno-unused-parameter -mcpu=cortex-m3 -mlittle-endian -mthumb -mfloat-abi=soft " \
	CXXFLAGS="-fdata-sections -ffunction-sections -Os -Wno-implicit-fallthrough -Wno-unused-parameter -mcpu=cortex-m3 -mlittle-endian -mthumb -mfloat-abi=soft -fno-exceptions -fno-rtti " \
	LDFLAGS="-fdata-sections -ffunction-sections -Os -Wno-implicit-fallthrough -Wno-unused-parameter -mcpu=cortex-m3 -mlittle-endian -mthumb -mfloat-abi=soft -nostartfiles -specs=nano.specs \
	-specs=nosys.specs -Wl,--gc-sections -Wl,-Map=map.map " \
	./configure --disable-docs --host=arm-none-eabi --target=arm-none-eabi \
	--prefix=/ --enable-default-logging --enable-cli-app=ftd --enable-application-coap
/bin/sh: 1: ./configure: not found
Makefile:24: recipe for target 'all' failed
make[1]: *** [all] Error 127

Any clues on what could be wrong?

aabadie · 2018-07-05T13:45:48Z

bootstrap: --automake: not found: It's still the same problem, Murdock workers are not providing automake. We can't merge this PR because of this.

jia200x · 2018-07-12T09:53:25Z

Triggered Murdock again, the riotdocker image is updated. So the workers I guess

aabadie · 2018-10-10T13:18:50Z

examples/openthread/README.md

+open source implementation of [Thread](https://threadgroup.org/) on RIOT.
+The [Command Line Interface](https://github.com/openthread/openthread/blob/master/examples/apps/cli/README.md) of
+OpenThread was ported. Please check the [full documentation]
+(https://github.com/openthread/openthread/blob/master/src/cli/README.md)


The link to full documentation is broken, see here
If you want to separate the paragraph, a new line is not enough, you have to add a blank line.

right. Just pushed the fix (fd96a55)

jia200x · 2018-10-10T13:29:27Z

@smling @kaspar030 for some reason Murdock still complains about automake, m4, libtool stuff :(
I tried to compile it with BUILD_IN_DOCKER=1 and the image works.

Any clue?

aabadie · 2018-10-10T15:19:13Z

Any clue?

The Murdock workers need to be updated with the latest docker image version. This is not done automatically and other remaining things may change apparently (use ubuntu bionic, etc)

jia200x · 2018-10-10T15:31:06Z

The Murdock workers need to be updated with the latest docker image version. This is not done automatically and other remaining things may change apparently (use ubuntu bionic, etc)

ping? @kaspar030 @smlng

aabadie

Tested this PR on IoT-LAB with iotlab-m3 and samr21-xpro boards. It works as expected: I could exchange pings and also tried the coap command with success.

Let's try to have this one into the release. ACK

jia200x · 2018-10-16T09:44:34Z

awesome! I will squash then ;)

jia200x · 2018-10-16T12:43:10Z

@aabadie there's an unrelated issue with pkg_libhydrogen

aabadie · 2018-10-16T12:53:06Z

there's an unrelated issue with pkg_libhydrogen

Saw that. I'm wondering why execution tests are run when only CI:ready for build label is set. Any idea ?

aabadie · 2018-10-16T15:23:49Z

and go !

jia200x · 2018-10-16T15:25:38Z

after 1 year!!! Thank you so much to everyone involved and special thanks to @biboc who was the original author of this PR!

Hyungsin · 2018-10-16T16:55:42Z

This is very encouraging! Thank you guys! 👍

biboc · 2018-11-21T12:29:31Z

Good job @jia200x !

How about NCP port?
I do think it is important since it can replace the actual RIOT BorderRouter and the port will be almost completed
Last thing missing was commissioning if I remember and I had problems with amount of free RAM for samr21-xpro

jia200x requested a review from aabadie June 12, 2018 15:53

jia200x mentioned this pull request Jun 12, 2018

pkg/openthread: add FTD-MTD-NCP tests #7149

Closed

aabadie requested changes Jun 12, 2018

View reviewed changes

jia200x added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 13, 2018

aabadie reviewed Jun 13, 2018

View reviewed changes

jia200x added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jul 12, 2018

jia200x added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jul 17, 2018

jia200x added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 10, 2018

aabadie reviewed Oct 10, 2018

View reviewed changes

jia200x added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 15, 2018

aabadie approved these changes Oct 16, 2018

View reviewed changes

jia200x force-pushed the openthread_ftd branch from fd96a55 to bf7b33b Compare October 16, 2018 09:49

jia200x added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 16, 2018

aabadie added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 16, 2018

jia200x added 6 commits October 16, 2018 15:25

pkg/openthread: add FTD and NCP support

2bf6d01

pkg/openthread: move dependencies to pkg Makefile.dep

74ec336

examples/openthread: move test to examples

b75ffb9

pkg/openthread: replace sed by patch

3a96652

pkg/openthread: adapt to newer stdio uart header file

6541678

examples/openthread: remove xtimer dependency

0ea488e

jia200x force-pushed the openthread_ftd branch from bf7b33b to 0ea488e Compare October 16, 2018 13:29

aabadie merged commit 77d97a6 into RIOT-OS:master Oct 16, 2018

jia200x mentioned this pull request Jan 7, 2019

[WIP] examples: add Wakaama/LwM2M example client #8610

Closed

Conversation

jia200x commented Jun 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution description

Issues/PRs references

Uh oh!

jia200x commented Jun 12, 2018

Uh oh!

aabadie left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jia200x commented Jun 13, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jia200x commented Jun 13, 2018

Uh oh!

jia200x commented Jun 13, 2018

Uh oh!

aabadie commented Jun 13, 2018

Uh oh!

jia200x commented Jun 13, 2018

Uh oh!

Hyungsin commented Jul 2, 2018

Uh oh!

aabadie commented Jul 3, 2018

Uh oh!

aabadie commented Jul 3, 2018

Uh oh!

jia200x commented Jul 5, 2018

Uh oh!

jia200x commented Jul 5, 2018

Uh oh!

jia200x commented Jul 5, 2018

Uh oh!

aabadie commented Jul 5, 2018

Uh oh!

jia200x commented Jul 12, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jia200x commented Oct 10, 2018

Uh oh!

aabadie commented Oct 10, 2018

Uh oh!

jia200x commented Oct 10, 2018

Uh oh!

aabadie left a comment

Choose a reason for hiding this comment

Uh oh!

jia200x commented Oct 16, 2018

Uh oh!

jia200x commented Oct 16, 2018

Uh oh!

aabadie commented Oct 16, 2018

Uh oh!

aabadie commented Oct 16, 2018

Uh oh!

jia200x commented Oct 16, 2018

Uh oh!

jia200x commented Jun 12, 2018 •

edited

Loading