sys/xtimer: remove redundant callback schedule for overflow#9489
Closed
Hyungsin wants to merge 1 commit intoRIOT-OS:masterfrom
Closed
sys/xtimer: remove redundant callback schedule for overflow#9489Hyungsin wants to merge 1 commit intoRIOT-OS:masterfrom
Hyungsin wants to merge 1 commit intoRIOT-OS:masterfrom
Conversation
Hyungsin
force-pushed
the
forupstream_xtimer_remove_redundancy
branch
7 times, most recently
from
0eb8de5 to
08c60ea
Compare
Hyungsin
force-pushed
the
forupstream_xtimer_remove_redundancy
branch
from
08c60ea to
88711cc
Compare
Author
|
closed in favor of #9530 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
xtimer schedules a callback on next overflow (_lltimer_set(0xFFFFFFFF)) when there is no timer in the current timer period.
However, if there is no xtimer EVEN in the future timer period (i.e., literally zero on-going xtimer), this next overflow callback does not have to be scheduled.
This PR removes such redundant overflow callback schedules, which reduces energy/time resource consumption by scheduling overflow callbacks only when necessary.
Issues/PRs references