Skip to content

at86rf2xx: uncrustify and changed parenthesis order of NETOPT_CSMA_RETRIES check#9508

Merged
kYc0o merged 2 commits intoRIOT-OS:masterfrom
Josar:pr/at86rf2xx_uncrustify
Jul 10, 2018
Merged

at86rf2xx: uncrustify and changed parenthesis order of NETOPT_CSMA_RETRIES check#9508
kYc0o merged 2 commits intoRIOT-OS:masterfrom
Josar:pr/at86rf2xx_uncrustify

Conversation

@Josar
Copy link
Contributor

@Josar Josar commented Jul 6, 2018

Uncrustified the at86rf2xx driver files.

Changed the parenthesis of NETOPT_CSMA_RETRIES to be better readable.

Issues/PRs references

#9172

@kYc0o
Copy link
Contributor

kYc0o commented Jul 6, 2018

As far as I can see, this is all editorial changes, which I find fine. I just would change the title of the PR accordingly. Can you change your last commit message to something like reorder parenthesis to improve readability ?

@kYc0o kYc0o self-assigned this Jul 6, 2018
@kYc0o kYc0o added Area: network Area: Networking Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jul 6, 2018
@kYc0o kYc0o added this to the Release 2018.07 milestone Jul 6, 2018
Reorder parenthesis to improve readability.
@Josar Josar force-pushed the pr/at86rf2xx_uncrustify branch from 96f7d86 to 86b4dd4 Compare July 6, 2018 14:52
@miri64 miri64 changed the title Pr/at86rf2xx uncrustify and correct NETOPT_CSMA_RETRIES at86rf2xx: uncrustify and correct NETOPT_CSMA_RETRIES Jul 7, 2018
@miri64 miri64 changed the title at86rf2xx: uncrustify and correct NETOPT_CSMA_RETRIES at86rf2xx: uncrustify and correct parenthesis order of NETOPT_CSMA_RETRIES check Jul 7, 2018
@Josar Josar changed the title at86rf2xx: uncrustify and correct parenthesis order of NETOPT_CSMA_RETRIES check at86rf2xx: uncrustify and changed parenthesis order of NETOPT_CSMA_RETRIES check Jul 10, 2018
@Josar
Copy link
Contributor Author

Josar commented Jul 10, 2018

@kYc0o done.

Copy link
Contributor

@kYc0o kYc0o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@kYc0o kYc0o merged commit f89b727 into RIOT-OS:master Jul 10, 2018
@Josar Josar deleted the pr/at86rf2xx_uncrustify branch July 10, 2018 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: drivers Area: Device drivers Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants