Conversation
kYc0o
left a comment
kYc0o
left a comment
There was a problem hiding this comment.
Minor nitpick. Can you link directly to the page in the reference manual where this is stated?
drivers/at86rf2xx/at86rf2xx_netdev.c
Outdated
| } | ||
|
|
||
| return pkt_len; | ||
| return pkt_len; |
There was a problem hiding this comment.
Please readd the 4 spaces here.
drivers/at86rf2xx/at86rf2xx_netdev.c
Outdated
| rssi = 3 * rssi; | ||
| #endif | ||
| radio_info->rssi = RSSI_BASE_VAL + rssi; | ||
| DEBUG("[at86rf2xx] LQI:%d high is good, RSSI:%d high good or interferer.\n", |
There was a problem hiding this comment.
I don't get what "high good or interferer" means?
There was a problem hiding this comment.
That this value represents either a good link or a lot of interference. Maybe a rephrasing like high is either good or too much interference?
|
@kYc0o directly link? |
|
That should be enough! Thanks!. Even better if added to the commit message, so they become part of the git history. |
|
I can do this when squash and rebase. Should i do this now? |
Agreed. |
|
@kYc0o done. |
|
@kYc0o further remarks? |
|
Not on my side. ACK. |
kYc0o
added
Area: network
AT86RF231 MAN. p.89 8.3.2 Reading RSSI AT86RF232 MAN. p.88 8.3.2 Reading RSSI AT86RF233 MAN. p.99 8.4.2 Reading RSSI "It is not recommended reading the RSSI value when using the Extended Operating Modes, use ED instead"
|
@kaspar030 could you have a second look if your concerns are addressed? |
|
Can this be merged? |
|
I'd say yes. |
3 participants
This PR changes the the rssi value to be based on the ED and not on the RSSI value as stated in the manuel for the extended operation mode of the 23x devices.
The ifdefs are reordered to to be extended more easier.
Issues/PRs references
#9172