shell/sc_can: fix uninitialized warning [backport 2018.07]#9644
Merged
miri64 merged 1 commit intoRIOT-OS:2018.07-branchfrom Jul 31, 2018
Merged
shell/sc_can: fix uninitialized warning [backport 2018.07]#9644miri64 merged 1 commit intoRIOT-OS:2018.07-branchfrom
miri64 merged 1 commit intoRIOT-OS:2018.07-branchfrom
Conversation
46 tasks
When compiled for `hifive1` board with `gcc-7.2.0` this warning was raised: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized] (cherry picked from commit eec88e3)
1c7c20d to
8462cfe
Compare
miri64
approved these changes
Jul 31, 2018
Member
miri64
left a comment
There was a problem hiding this comment.
Ok, change looks simple and I confirmed, that in the current release branch this issue exist and it is indeed fixed by this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #9627
Contribution description
When compiled for
hifive1board withgcc-7.2.0this warning was raised:'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized]
This was first mentioned in RIOT-OS/riotdocker#42 (comment)
Testing
The board does not have enough memory but the error is triggered when compiling with a
gccversion7.2.0:Warning is dismissed, it was just a testing procedure error.
Issues/PRs references
#9405
RIOT-OS/riotdocker#42
Found it during release testing