Skip to content

core: Mark openocd info variables read-only#9843

Merged
jnohlgard merged 1 commit intoRIOT-OS:masterfrom
jnohlgard:pr/core-openocd-ro
Aug 29, 2018
Merged

core: Mark openocd info variables read-only#9843
jnohlgard merged 1 commit intoRIOT-OS:masterfrom
jnohlgard:pr/core-openocd-ro

Conversation

@jnohlgard
Copy link
Member

@jnohlgard jnohlgard commented Aug 25, 2018

Contribution description

These are not changing during runtime, they are only accessed by openocd when debugging. Marking them const lets the linker place them in ROM.

Testing procedure

  1. Flash a binary
  2. make debug with a RIOT patched openocd (https://github.com/daniel-k/openocd/tree/riot_patched, http://openocd.zylin.com/#/c/3000/)
  3. info threads should show the running threads after the system has booted

Issues/PRs references

split from #9104 to ease review

@jnohlgard jnohlgard added Area: core Area: RIOT kernel. Handle PRs marked with this with care! Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 25, 2018
@jnohlgard jnohlgard added this to the Release 2018.10 milestone Aug 25, 2018
@jnohlgard jnohlgard requested a review from kaspar030 August 25, 2018 13:05
smlng
smlng approved these changes Aug 29, 2018
View reviewed changes
Copy link
Member

@smlng smlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@jnohlgard jnohlgard merged commit 92ef336 into RIOT-OS:master Aug 29, 2018
@jnohlgard jnohlgard deleted the pr/core-openocd-ro branch August 29, 2018 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaspar030 kaspar030 Awaiting requested review from kaspar030 kaspar030 is a code owner

1 more reviewer

@smlng smlng smlng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area: core Area: RIOT kernel. Handle PRs marked with this with care! CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Milestone

Release 2018.10

Development

Successfully merging this pull request may close these issues.

2 participants

@jnohlgard @smlng