riotctrl.ctrl: add flash method for RIOTCtrl#22
Merged
miri64 merged 4 commits intoRIOT-OS:masterfrom Sep 9, 2021
Merged
Conversation
fjmolinas
previously approved these changes
Sep 9, 2021
Contributor
fjmolinas
left a comment
fjmolinas
left a comment
There was a problem hiding this comment.
ACK, nice makes sense to have this!
miri64
force-pushed
the
riotctrl/enh/flash-function
branch
from
9133d6a to
1b23aac
Compare
Member
Author
|
Force pushed to trigger a new build. The one that succeeded was quite stale. Can you Re-ACK please. |
Member
Author
|
New pylint was not happy. Will provide fixes :-). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
flashmethod for RIOTCtrl. The idea is, that with #13 an inherited class can easily override it, that e.g. withiotlabcliit only has to be called once for all nodes.