ctrl: send termination signals to the process group#37
Merged
maribu merged 2 commits intoRIOT-OS:masterfrom Apr 26, 2025
crasbe:pr/kill_pgroup
Merged
ctrl: send termination signals to the process group#37maribu merged 2 commits intoRIOT-OS:masterfrom crasbe:pr/kill_pgroup
maribu merged 2 commits intoRIOT-OS:masterfrom
crasbe:pr/kill_pgroup
Conversation
Contributor
Author
|
Since this is not released yet, you'll have to copy the modified file to your |
Contributor
Author
|
Uargh this is just stupid. So the only valid workaround is to add the |
The native platform on RIOT spawns two processes instead of one, so that sending the termination signal to just one process might leave a stray process open. This causes a PTY leak and eventually breaks the CI servers.
maribu
approved these changes
Apr 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The native platform on RIOT spawns two processes instead of one, so that sending the termination signal to just one process might leave a stray process open. This causes a PTY leak and eventually breaks the CI servers.
With the current
master:With this PR: