workflows,tox: add more python versions, fix too-many-positional-arguments warning for all versions#40
Merged
maribu merged 3 commits intoRIOT-OS:masterfrom Apr 26, 2025
crasbe:fix_lint
Merged
workflows,tox: add more python versions, fix too-many-positional-arguments warning for all versions#40maribu merged 3 commits intoRIOT-OS:masterfrom crasbe:fix_lint
too-many-positional-arguments warning for all versions#40maribu merged 3 commits intoRIOT-OS:masterfrom
crasbe:fix_lint
Conversation
Starting from the pylint version that is pulled with Python 3.9, it checks for the amount of positional arguments in a function. The __init__ function has too many and the warning can only be disabled for newer versions, therefore tox has to conditionally check it.
Contributor
Author
|
Finally... 🫠 I think it would've been easier just to change the number of positional arguments in the |
maribu
approved these changes
Apr 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately the fix introduced in 5e679ed caused an issue with the earlier pylint versions that somehow did not get caught by the workflow.
Therefore, this PR introduces a more stable fix that adds a condition for newer and older python versions.
Also I added more Python versions to the
tox.inifile to cover version 3.12 that is tested in the Workflows as well (and I have 3.10 locally, which was not covered either).