Simplify c2rust (with latest C2Rust version)#199
Merged
bors[bot] merged 3 commits intoRIOT-OS:masterfrom Jun 14, 2022
Merged
Conversation
This has become possible now that it doesn't need fancy build dependencies any more.
Closed
Member
Author
|
Build failure is being investigated, looks like they broke something in the Cargo.toml workspace setup -- it's a build system issue. |
This unblocks a stage of [#18056]. [#18056]: RIOT-OS/RIOT#18056
chrysn
force-pushed
the
simplify-c2rust-with-20220614-update
branch
from
ad12171 to
6c4b5ef
Compare
Member
Author
|
Downgraded C2Rust in a hotfix again by a bit: Starting a commit later it is using a more recent Rust version that we currently ship (the latest stable) -- not a problem to upgrade, but not a thing I'd want to tangle in here either. |
Member
Author
|
nagh ... and now something is leaving root-owned files in /data/riotbuild; debugging... |
Merely running earlier docker containers with `--user $(id -u)` would be insufficient because some make runs are issued outside of docker with root privileges as well.
chrysn
force-pushed
the
simplify-c2rust-with-20220614-update
branch
from
ad11819 to
bee55e5
Compare
Member
Author
|
Build troubles resolved, I think this is ready for review now. (Also pinging @aabadie as this unblocks RIOT-OS/RIOT#18056) |
aabadie
reviewed
Jun 14, 2022
Contributor
|
bors merge |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is equivalent to #196 (also fixing RIOT-OS/RIOT#18056) except that it is
(Opened as a separate PR because if this fails for some reason, it's easy to fall back to #196).