CI: Test Rust both with hello-world and gcoap example#209
Merged
bors[bot] merged 1 commit intoRIOT-OS:masterfrom Sep 27, 2022
Merged
CI: Test Rust both with hello-world and gcoap example#209bors[bot] merged 1 commit intoRIOT-OS:masterfrom
bors[bot] merged 1 commit intoRIOT-OS:masterfrom
Conversation
Build failures after RIOT-OS#189 show that the test coverage is insufficient to catch C2Rust breakage; this mitigates it by building an example that pulls in much more code.
Merged
Contributor
|
this will currently fail, right? bors merge |
Member
Author
|
Yes, I hope so. (Otherwise the issue would be way harder to track). I have no clue whether the follow-up #210 would pass. |
Member
Author
|
Sadly, it did pass. Curious for bors' result, but AIU it's doing the very tests that the build target does (it just merges with master before, but as this forks off master, that's a no-op). |
Contributor
|
Build succeeded: |
Member
Author
|
It turned out that this was not the issue (rather, no RISC-V have been run at all), but still, this gives way better code coverage, so it's still a win. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build failures after #189 show that the test coverage is insufficient to catch C2Rust breakage; this mitigates it by building an example that pulls in much more code.
[edit: Also, this is a good base to look into whether this needs / can be fixed on the image rather than on the Rust side, and it keeps pressure off Murdock by testing it here].