Skip to content

add protobuf-compiler as a requirement #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benpicco wants to merge 1 commit into from
Closed

add protobuf-compiler as a requirement #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,4 @@ ed25519==1.4
cbor==1.0.0
cryptography==2.6.1
scapy>=2.4.3
protobuf-compiler>=3.0.0
Copy link
Contributor

@kaspar030 kaspar030 Sep 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

travis fails, cannot find that package. https://pypi.org/project/protobuf-compiler/ shows v1.0.20 is current?

Copy link
Contributor Author

@benpicco benpicco Sep 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh so these are Python modules - then this PR is of course wrong.

Copy link
Contributor

@kaspar030 kaspar030 Sep 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh so these are Python modules - then this PR is of course wrong.

Now I lost confidence that you've actually tried to build the container yourself. 😉

Copy link
Contributor Author

@benpicco benpicco Sep 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github provides such a nice interface for making small edits to text files, I might have used just that…