Skip to content

requirements.txt: document that it contains python libraries#85

Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom
miri64:doc-requirements.txt
Sep 12, 2019
Merged

requirements.txt: document that it contains python libraries#85
miri64 merged 1 commit intoRIOT-OS:masterfrom
miri64:doc-requirements.txt

Conversation

@miri64
Copy link
Member

@miri64 miri64 commented Sep 12, 2019

See #83 (comment) ;-)

Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess people who used Docker before might have already known 😅
But a little comment sure can't hurt for those who haven't.

@miri64
Copy link
Member Author

miri64 commented Sep 12, 2019

I guess people who used Docker before might have already known

It's not docker, it's our Dockerfile ;-). Calling the requirements file requirements.txt is a python convention, so if you never wrote a python package, the confusion is understandable ;-).

See also #56 for historical reference ;-)

@miri64 miri64 merged commit 6ecebc2 into RIOT-OS:master Sep 12, 2019
@miri64 miri64 deleted the doc-requirements.txt branch September 12, 2019 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants