Skip to content

codespell: install via pip instead of apt#88

Merged
kaspar030 merged 1 commit intoRIOT-OS:masterfrom
aabadie:codespell_pip
Sep 24, 2019
Merged

codespell: install via pip instead of apt#88
kaspar030 merged 1 commit intoRIOT-OS:masterfrom
aabadie:codespell_pip

Conversation

@aabadie
Copy link
Contributor

@aabadie aabadie commented Sep 23, 2019

Unfortunately the version of codespell installed by apt doesn't contain some of the options used in RIOT-OS/RIOT#12232

This PR is installing codespell via pip3 with the latest current version (1.16) to be sure all required features can be used.

@aabadie aabadie requested a review from kaspar030 September 23, 2019 22:08
This ensures a decent version is installed with all required features
@aabadie
Copy link
Contributor Author

aabadie commented Sep 24, 2019

The version installed is the right one:

$ docker build . -t riot/riotbuild
$ docker run -ti --rm riot/riotbuild /bin/bash
root@3ea93c11e4c3:~# codespell --version
1.16.0

Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@kaspar030 kaspar030 merged commit ff80892 into RIOT-OS:master Sep 24, 2019
@aabadie aabadie deleted the codespell_pip branch December 16, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants