Skip to content

Add missing equals in some domain objects #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ties wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add missing equals in some domain objects #170

ties wants to merge 1 commit into from

Conversation

@ties
Copy link
Member

@ties ties commented Apr 17, 2024

  • I have updated the changelog in README.md

@ties ties requested a review from bjpbakker April 17, 2024 12:46
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 17, 2024
View reviewed changes
src/main/java/net/ripe/rpki/commons/ta/domain/request/SigningRequest.java
import org.apache.commons.lang3.Validate;

@Getter
@EqualsAndHashCode(callSuper = true)

Check notice

Code scanning / CodeQL

Missing Override annotation

This method overrides [TaRequest.canEqual](1); it is advisable to add an Override annotation.
src/main/java/net/ripe/rpki/commons/ta/domain/request/RevocationRequest.java
* Ask Trust Anchor to revoke all certificates that use the provided public key.
*/
@Getter
@EqualsAndHashCode(callSuper = true)

Check notice

Code scanning / CodeQL

Missing Override annotation

This method overrides [TaRequest.canEqual](1); it is advisable to add an Override annotation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjpbakker bjpbakker Awaiting requested review from bjpbakker

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ties