HTTP client tweaks #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolepezy
reviewed
Jun 26, 2023
| * The full URL is in a high cardinality value (which would be used by observability tools) | ||
| */ | ||
| @Bean | ||
| public ClientRequestObservationConvention nonUriClientRequestObservationConvention() { |
Contributor
There was a problem hiding this comment.
That is to not have unique tag for every new snapshot URL, right?
Member
Author
There was a problem hiding this comment.
That is what it should do, yeah. Think this is the spring magic way to go
Contributor
|
This PR is to replace |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connect-to, but not here. Since theconnect-tofunctionality was stripped, let's remove the full builder.