Skip to content

ci: fix environment variables setup in GitHub Actions workflow#23

Closed
jdhoffa wants to merge 17 commits intomainfrom
fix_gh_action_build_envvars
Closed

ci: fix environment variables setup in GitHub Actions workflow#23
jdhoffa wants to merge 17 commits intomainfrom
fix_gh_action_build_envvars

Conversation

@jdhoffa
Copy link
Collaborator

@jdhoffa jdhoffa commented Apr 15, 2025

This PR improves the GitHub Actions workflow configuration to properly handle environment variables and secrets.

Changes:

  • Fixed missing environment variables in the Docker Compose setup
  • Added direct values for essential variables (ports, model names, log levels)
  • Properly separated sensitive information (passwords, API keys) as secrets
  • Improved variable references using GitHub's environment variables syntax
  • Added documentation on proper usage of repository variables and secrets

Benefits:

  • Resolves CI failures due to missing environment variables
  • Ensures sensitive data is properly protected
  • Provides consistent environment for system tests
  • Maintains default values for non-sensitive configuration

The workflow now correctly sets up the database, API, and LLM engine variables needed for Docker Compose to run the system tests successfully.

@jdhoffa jdhoffa requested a review from Copilot April 15, 2025 16:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

@jdhoffa jdhoffa closed this Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants