fix(query_router): rename query_runner to query_router and fix service configuration#24
Merged
fix(query_router): rename query_runner to query_router and fix service configuration#24
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR renames the query service from query_runner to query_router and updates its service configuration, environment variables, and documentation. Key changes include:
- Deleting the old query_runner code and introducing new query_router service code.
- Updating Docker Compose, Cargo.toml, and CI workflow files to reflect the new naming and configuration.
- Enhancing error handling and healthchecks in the new query_router service.
Reviewed Changes
Copilot reviewed 7 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| query_runner/src/main.rs | Removed the old query_runner service implementation. |
| query_router/src/main.rs | Added new query_router service code with improved endpoints. |
| query_router/Cargo.toml | Updated package name and dependency versions. |
| docker-compose.yml | Adjusted service definitions and healthchecks for query_router. |
| README.md | Updated instructions and examples to reference query_router. |
| .github/workflows/ci.yml | Modified working directories and service names for CI. |
| .github/workflows/build.yml | Updated build context and tags to reference query_router. |
Files not reviewed (4)
- .env.example: Language not supported
- api/Dockerfile: Language not supported
- llm_engine/Dockerfile: Language not supported
- query_router/Dockerfile: Language not supported
Comments suppressed due to low confidence (1)
query_router/src/main.rs:150
- The error message instructs to set the 'PORT' environment variable, but the service uses 'QUERY_ROUTER_PORT'. Please update the error message to reference 'QUERY_ROUTER_PORT' for consistency.
tracing::error!("Port {} is already in use. Try setting a different port with the PORT environment variable.", port);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issues with the query service configuration and naming inconsistency.
Changes:
query_runnertoquery_routeracross the codebase for consistencyTesting:
All services now start correctly using
docker compose upwith proper dependency resolution and port configurations.