Merged
Conversation
Expected version change and release notes:1.5.0-dev.21 (v1.5.0-dev.20...fix/typecheck-index-gen ) (2025-11-06T10:05 UTC)Fixes
Continuous Integration and Delivery (CI/CD)
Tests
Other
|
jdhoffa
approved these changes
Nov 6, 2025
Collaborator
jdhoffa
left a comment
jdhoffa
left a comment
There was a problem hiding this comment.
Very happy with this approach. I wasn't sure if you wanted schema in there for some particular reason 😊
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the schema metadata field from the timeseries index structure. The schema field (containing version and generatedAt properties) was previously included in the generated index but is no longer needed.
Key changes:
- Removed
schemaproperty from theTimeseriesIndextype definition in both the generator script and generated type file - Updated the build script comment to reflect that only
byPathwayandbyDatasetare written - Removed
schemaproperty from test fixtures to align with the updated structure - Added TypeScript composite project configuration to
tsconfig.node.jsonfor build caching and included the generated index file
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/build-timeseries-files.ts | Updated type definition and documentation comment to remove schema field from generated output |
| src/data/index.gen.ts | Removed schema property from TimeseriesIndex type definition |
| src/utils/timeseriesIndex.test.ts | Removed schema property from test fixture to match updated type |
| tsconfig.node.json | Added composite project settings and included generated index file in compilation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-glacier-0f640931e-529.westus2.2.azurestaticapps.net |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #521
addresses typecheck issues without adding the (noisy on infrequent update) schema to the file