Skip to content

remove pathwayType "Direct Policy" and reclassify pathways#738

Merged
jacobvjk merged 6 commits intomainfrom
update-pathway-type
Mar 4, 2026
Merged

remove pathwayType "Direct Policy" and reclassify pathways#738
jacobvjk merged 6 commits intomainfrom
update-pathway-type

Conversation

@jacobvjk
Copy link
Collaborator

@jacobvjk jacobvjk commented Mar 3, 2026

closes Monday.com ticket https://rmi.monday.com/boards/18392757091/pulses/11362424193

  • removes pathway type "Direct Policy" throughout the repository
  • reclassifies the affected pathways

Copilot AI review requested due to automatic review settings March 3, 2026 16:54
@jacobvjk jacobvjk changed the title remove policyType direct policy and reclassify remove policyType "Direct Policy" and reclassify pathways Mar 3, 2026
@jacobvjk jacobvjk changed the title remove policyType "Direct Policy" and reclassify pathways remove pathwayType "Direct Policy" and reclassify pathways Mar 3, 2026
@github-actions
Copy link

github-actions bot commented Mar 3, 2026

Expected version change and release notes

🚨 WARNING: This PR is not expected to trigger a new version

To trigger a version bump, use at least one conventional commit message in this branch. See: https://www.conventionalcommits.org/en/v1.0.0/

@github-actions
Copy link

github-actions bot commented Mar 3, 2026

Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-glacier-0f640931e-738.westus2.2.azurestaticapps.net

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the "Direct Policy" pathway type across the app by updating the schema/type definitions and reclassifying existing pathway records to the remaining pathway types, keeping UI ordering/tooltips and tests in sync.

Changes:

  • Removed "Direct Policy" from the v1 schema/type union and regenerated schema documentation.
  • Updated UI utilities (tooltips + sorting order) and adjusted related unit/component tests.
  • Reclassified affected pathway metadata JSON files and examples to "Normative" / "Exploratory".

Reviewed changes

Copilot reviewed 15 out of 16 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
testdata/valid/pathwayMetadata_sample_03.json Updates sample metadata to use a supported pathwayType.
src/utils/tooltipUtils.ts Removes tooltip copy for the deleted pathway type.
src/utils/sortUtils.ts Removes "Direct Policy" from the fixed sort ordering.
src/utils/sortUtils.test.tsx Updates sorting tests to reflect the new 3-type ordering.
src/utils/searchUtils.test.tsx Updates filtering and facet option ordering expectations after type removal.
src/types/pathwayMetadata.v1.d.ts Removes "Direct Policy" from the pathwayType union.
src/schema/pathwayMetadata.v1.json Removes "Direct Policy" from the schema enum.
src/data/un-sdsn-cw/SDSN-CW-BAU-SG-2024.json Reclassifies pathway type away from "Direct Policy".
src/data/philippines-department-of-energy/PHDOE-REFERENCE-2023.json Reclassifies pathway type away from "Direct Policy".
src/data/philippines-department-of-energy/PHDOE-CES2-2023.json Reclassifies pathway type away from "Direct Policy".
src/data/philippines-department-of-energy/PHDOE-CES1-2023.json Reclassifies pathway type away from "Direct Policy".
src/data/README.md Updates the R example to use a supported pathwayType.
src/components/StepByStepGuide.tsx Removes "Direct Policy" from pathway-type descriptions shown in the guide.
src/components/SearchSection.test.tsx Updates UI test expectations for available pathway types.
src/components/Badge.test.tsx Updates badge tooltip tests for the supported pathway types.
public/schema/pathwayMetadata.v1.html Updates rendered schema docs to remove the deleted enum value.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Mar 3, 2026

Expected version change and release notes:

1.12.0-dev.1 (v1.11.1-dev.1...update-pathway-type ) (2026-03-04T12:20 UTC)

Features

  • remove pathwayType Direct Policy (9ab5c86)

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Mar 3, 2026

Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-glacier-0f640931e-738.westus2.2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Mar 3, 2026

Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-glacier-0f640931e-738.westus2.2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Mar 4, 2026

Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-glacier-0f640931e-738.westus2.2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Mar 4, 2026

Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-glacier-0f640931e-738.westus2.2.azurestaticapps.net

Copy link
Collaborator

@AlexAxthelm AlexAxthelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

@AlexAxthelm
Copy link
Collaborator

Not sure why updating branch didn't trigger comment, but expected version info:

Expected version change and release notes:

1.12.0-dev.1 (v1.11.1-dev.1...update-pathway-type ) (2026-03-04T12:20 UTC)

Features

  • remove pathwayType Direct Policy (9ab5c86)

@jacobvjk jacobvjk merged commit e82f9eb into main Mar 4, 2026
11 checks passed
@jacobvjk jacobvjk deleted the update-pathway-type branch March 4, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants