Conversation
Member
GyuH13
commented
Apr 27, 2026
GyuH13
commented
- Change the url that is used when git clone the cyclo manager source
- Consolidated the follower services into one, and the leader services into another.
- Remove novnc command in container.sh (novnc will provide through cyclo manager)
… kill process in finish script
Signed-off-by: Hyungyu Kim <kimhg@robotis.com>
…feature-zenoh-updates
Signed-off-by: Hyungyu Kim <kimhg@robotis.com>
…5, bh5) and improve error messaging for robot type validation.
…move branch specification from cyclo_manager git clone command.
…to ensure packages are up-to-date before installation.
…on to avoid BuildKit UndefinedVar warning and ensure apt-get upgrade is executed before package installation.
…plify container management by consolidating commands for starting and stopping the container.
…to streamline configuration and ensure proper newline at the end of container.sh file.
…o streamline package installation process.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the project version to 1.2.2 and transitions the system manager from talos to cyclo_manager. The ROS 2 longrun services have been unified into ai_worker_bringup and avatar_bringup, and the docker/container.sh script was simplified by removing noVNC-related logic. Review feedback highlights a critical issue where manually stopping logging services in the finish script may break s6-supervise restarts. Additionally, improvements were suggested regarding the removal of redundant shell wrappers, avoiding interactive shells for system services, and ensuring multi-line launch arguments are parsed correctly.
… for arm64 to streamline package management.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.