Bump 1.3.0#98
Merged
robotpilot merged 9 commits intojazzyfrom May 6, 2026
Merged
Conversation
Signed-off-by: Sungho Woo <wsh@robotis.com>
Signed-off-by: Sungho Woo <wsh@robotis.com>
Signed-off-by: Sungho Woo <wsh@robotis.com>
Signed-off-by: Sungho Woo <wsh@robotis.com>
Signed-off-by: Sungho Woo <wsh@robotis.com>
Signed-off-by: Sungho Woo <wsh@robotis.com>
Improved 3-wheel swerve steering limit using flip logic
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the package version to 1.3.0 across multiple packages and includes significant improvements to the swerve drive controller, specifically implementing a smooth 180-degree steering reversal logic and optimizing the real-time update loop. The review identified several critical issues, including unsafe usage of std::optional::value() which could cause runtime exceptions, a typo in a member variable name, and an unnecessary bias introduced in the atan2 calculation. The reviewer also suggested improvements for handling hardware state reading failures to ensure robustness in the real-time control loop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.