SWDEV-561590 - hipcc/ld.lld unable to link separable compilation when… #437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dynamic library is fully specified
|
Should we move this PR upstream? Looks like the PSDB passed |
omor1
reviewed
Nov 6, 2025
| } else if (isGPUBinHandleSymbol && (!isHidden) ) { | ||
| DefinedGPUBinHandleSymbols.insert(Name.str()); | ||
| GPUBinHandleSymbols.erase(Name.str()); | ||
| } |
There was a problem hiding this comment.
- if (!isUndefined) {
+ if (!isUndefined && !isHidden) {
if (isFatBinSymbol) {
DefinedFatBinSymbols.insert(Name.str());
FatBinSymbols.erase(Name.str());
- } else if (isGPUBinHandleSymbol && (!isHidden) ) {
+ } else if (isGPUBinHandleSymbol) {
DefinedGPUBinHandleSymbols.insert(Name.str());
GPUBinHandleSymbols.erase(Name.str());
}I don't recall if I've specifically seen that __hip_fatbin symbols have the same issue, but it's probably best to avoid that issue as well if it crops up.
There was a problem hiding this comment.
Thanks @omor1. You're right. Sam suggested we just remove the code to add these symbols if they are already defined. I've added a new commit. And the change is for both of the _hip symbols.
david-salinas
force-pushed
the
amd/dev/dsalinas/swdev-561590
branch
from
4bd0cf7 to
c275297
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… dynamic library is fully specified