tolerance and doc comments #98
Open
+13
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
TorreZuk
commented
Apr 22, 2024
TorreZuk
commented
- same sum reduction as f16
- left in some doc comments
TorreZuk
requested review from
NaveenElumalaiAMD,
amcamd,
bragadeesh,
daineAMD,
mahmoodw and
rkamd
as code owners
TorreZuk
force-pushed
the
bf16-reduce-tolerance-req
branch
2 times, most recently
from
a7f5180 to
8b51f2c
Compare
daineAMD
approved these changes
Jul 26, 2024
Contributor
daineAMD
left a comment
daineAMD
left a comment
There was a problem hiding this comment.
Can't vouch for groovy changes but looks like the job is running fine; everything else looks good.
TorreZuk
force-pushed
the
bf16-reduce-tolerance-req
branch
from
bce308b to
3963a01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.