Closed
Conversation
cwisniew
reviewed
Mar 18, 2026
cwisniew
reviewed
Mar 20, 2026
cwisniew
requested changes
Apr 2, 2026
| @Nonnull | ||
| public String resolve(@Nonnull final String path) { | ||
| var location = current.resolveSibling(path).normalize().toString(); | ||
| var location = current.resolveSibling(path).normalize().toString().replace('\\', '/'); |
Member
There was a problem hiding this comment.
This is not needed, please remove and just use / not \ as you are supposed to in a URL! Don't let windows path seperator start infecting things
| private static final HighConcurrencyTemplateCache HIGH_CONCURRENCY_TEMPLATE_CACHE = | ||
| new HighConcurrencyTemplateCache(); | ||
|
|
||
| static Handlebars getHandlebarsInstance(@Nullable TemplateLoader loader) { |
Member
There was a problem hiding this comment.
Add some Javadoc that explaines what happens this method, especially what happens if loader is null as it wont be obvious to anyone but it is marked as nullable
bubblobill
force-pushed
the
handlebarsHelpers
branch
from
b19ee56 to
58f21da
Compare
Collaborator
Author
|
What the hell - grrrr... I did not close this - damnit |
Collaborator
Author
|
Reopen damn you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
progresses #4158
Description of the Change
added handlebars helpers.
added template cache.
LibraryTemplateLoader class changes:
Normally it is not noticable, but on consecutive nested calls (i.e. calls to templates inside a template, as used in the
includehelper), Windows paths break the URL lookup, .e.g. when the first character is checked for/but it is a\.New helper list;
previously existing helpers
new helpers
Possible Drawbacks
things don't work as I think they should
Documentation Notes
added handlebars helpers.
This change is