Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daleunixal
reviewed
Sep 20, 2021
| function isTriangle(a, b, c) { | ||
| function isTriangle(a, b, c) | ||
| { | ||
| return ((a + b > c) && (a + c > b) && (b + c > a)) | ||
| } | ||
|
|
topic-1/task-2/index.js
Outdated
| let doubledArray = []; | ||
| for (i = 0; i < array.length; i++) | ||
| { | ||
| if (array[i] !==0) |
There was a problem hiding this comment.
0 - свободная ячейка.
Если она будет в начале массива, то твое решение завалит работу.
Пример:
[0,1,2,0,3,3,0,0]
topic-1/task-3/index.js
Outdated
| return 1; | ||
| } | ||
| else { | ||
| return n * factorial(n - 1); |
There was a problem hiding this comment.
Не забываем про отступы при вложенности.
- лучше избегать рекурсивных вызовов функций
Каждый такой вызов будет создавать вспомогательный контекст в стеке, что потребует дополнительных ресурсов, как временных, так и по памяти.
| } | ||
| else { | ||
| return n * factorial(n - 1); | ||
| } | ||
| } |
| doubledArray.push(array[i]); | ||
| doubledArray.push(array[i]); | ||
| } | ||
| } |
daleunixal
reviewed
Sep 20, 2021
|
|
||
| function calculateDoubleArray(array) | ||
| { | ||
| let doubledArray = []; |
| } | ||
|
|
||
| } | ||
| return doubledArray; |
| } | ||
|
|
| @@ -7,6 +7,13 @@ | |||
| * @return {number} Количество уникальных имён | |||
| * */ | |||
| function countUniqueName(nameArray) { | |||
| let names = []; | |||
| names.push(highWord); | ||
| } | ||
| } | ||
| return names.length; | ||
| } |
| let names = []; | ||
| for (let word of nameArray) { | ||
| let highWord = word.toUpperCase(); | ||
| if (!names.includes(highWord)) { |
There was a problem hiding this comment.
Решение достаточное.
Совет на будущее. Set работает намного эффективнее в сравнивании и прочем. Если захочешь разобраться, можешь подойти, разберем вместе)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.