Add retry capabilities for download file util#502
Open
d33bs wants to merge 1 commit intoRTXteam:masterfrom
Open
Add retry capabilities for download file util#502d33bs wants to merge 1 commit intoRTXteam:masterfrom
d33bs wants to merge 1 commit intoRTXteam:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #365 by adding retry capabilities to the function when attempting to download files.
I tried this out some time ago and it seemed to work but haven't tested this with later revisions in this project. That said, it could be useful to add a software test for this (and maybe other code) in the project under a
/testsdirectory to help confirm minimum capability prior to full / partial execution of the full project. Let me know if this is of interest and I will add something in.