Skip to content

Conversation

@ddemeyer
Copy link
Contributor

@ddemeyer ddemeyer commented Jan 9, 2026

…-IshSession and adapted all BeginProcessing in all cmdlets to fall back from local: to global:

…-IshSession and adapted all BeginProcessing in all cmdlets to fall back from local: to global:
@ddemeyer ddemeyer requested a review from Copilot January 9, 2026 18:49
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements a fallback mechanism for session state retrieval by adding support for global-scoped ISHRemoteSessionStateIshSession variables. When cmdlets cannot find a session in the local scope, they now fall back to checking the global scope.

Changes:

  • Added global scope fallback for IshSession retrieval across all cmdlets
  • Updated New-IshSession to store session in both local and global scopes
  • Added test coverage for both local and global session state storage

Reviewed changes

Copilot reviewed 85 out of 85 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
TrisoftCmdlet.cs Defines new global session constant and updates documentation
NewIshSession.cs Stores IshSession in both local and global scope variables
NewIshSession.Tests.ps1 Adds tests verifying both local and global session storage
GetIshTypeFieldDefinition.cs Adds global scope fallback in ProcessRecord method
GetIshTypeFieldDefinition.Tests.ps1 Updates test to handle both local and global session state
Multiple cmdlet files Adds global scope fallback and updates debug messages in BeginProcessing

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ddemeyer ddemeyer merged commit 2bdd6aa into master Jan 9, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants