Add mapFeature field to link quest objectives to map nodes#257
Open
kirillsst wants to merge 1 commit intoRaidTheory:mainfrom
Open
Add mapFeature field to link quest objectives to map nodes#257kirillsst wants to merge 1 commit intoRaidTheory:mainfrom
kirillsst wants to merge 1 commit intoRaidTheory:mainfrom
Conversation
Add optional mapFeature field to objectives in a_lay_of_the_land.json as a proof of concept for linking quest objectives to interactive map features. This addresses RaidTheory#99 by enabling navigation from quest pages to the corresponding map nodes.
Contributor
|
I find the idea cool! I would not mix the map links in mids of the translations. There needs to be a structure here, like: "objectives": [
...
{
"description": {
"da": "Find fragtsedlerne på formandens kontor",
"de": "Finde die Versandnotizen im Büro des Vorarbeiters.",
"en": "Find the shipping notes in the foreman’s office",
...
},
"mapFeature": {
"map": "the_spaceport",
"feature": 52
}
}That of course requires a change in the structure and people using will have to adapt to that, but I think currently there is no flexibility inside each step of the objectives, and we might want to add more data to each step in future (i.e. the "Deliver" => "itemId" etc). What do you think @mattmarcin ?? |
Contributor
|
The |
Contributor
|
dont forget to account for different parts of the mission in different maps too, i can see this becoming very convoluted with all the data. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional
mapFeaturefield to quest objectives, enabling direct linking from quest pages to interactive map features.This is a proof-of-concept implementation for
a_lay_of_the_land.jsonquest, linking two objectives to their corresponding Spaceport map features:Format
The field is optional and only added to objectives that have a corresponding map location:
{ "en": "Find the shipping notes in the foreman's office", "mapFeature": { "map": "the_spaceport", "feature": 52 }, ... }This allows the frontend to construct links like:
/api/maps/the-spaceport?feature=52Next steps
If this approach looks good, the same field can be added to other quests that reference specific map locations.
Closes #99