Skip to content

Some code cleanup and re-order, reduces blib\Raku\Grammar.moarvm about 95KB #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zhuomingliang
Copy link
Member

No description provided.

@zhuomingliang zhuomingliang force-pushed the zhuomingliang/cleanup branch from d8ba4b9 to 23da905 Compare April 23, 2025 02:50
@zhuomingliang zhuomingliang changed the title Some code cleanup and re-order, reduces blib\Raku\Grammar.moarvm about 43KB Some code cleanup and re-order, reduces blib\Raku\Grammar.moarvm about 65KB Apr 23, 2025
@zhuomingliang zhuomingliang force-pushed the zhuomingliang/cleanup branch from 23da905 to 71118c3 Compare April 23, 2025 11:18
Reduces blib\Raku\Grammar.moarvm about 95KB size
@zhuomingliang zhuomingliang force-pushed the zhuomingliang/cleanup branch from 71118c3 to 1339dab Compare April 23, 2025 11:49
@MasterDuke17
Copy link
Contributor

A Rakudo spectest with NQP built on this branch:

Test Summary Report
-------------------
t/spec/6.c/APPENDICES/A04-experimental/01-misc.rakudo.moar    (Wstat: 0 Tests: 19 Failed: 0)
  TODO passed:   1
t/spec/6.c/S04-declarations/my-6c.rakudo.moar                 (Wstat: 0 Tests: 112 Failed: 0)
  TODO passed:   61
t/spec/S02-names-vars/signature.t                             (Wstat: 256 (exited 1) Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
t/spec/S02-types/pair.rakudo.moar                             (Wstat: 256 (exited 1) Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
t/spec/S02-types/num.rakudo.moar                              (Wstat: 256 (exited 1) Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
t/spec/S02-types/whatever.rakudo.moar                         (Wstat: 256 (exited 1) Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
t/spec/S03-metaops/cross.t                                    (Wstat: 256 (exited 1) Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
t/spec/S03-junctions/misc.t                                   (Wstat: 256 (exited 1) Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
t/spec/S03-metaops/not.rakudo.moar                            (Wstat: 256 (exited 1) Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
t/spec/S03-metaops/reverse.t                                  (Wstat: 256 (exited 1) Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
t/spec/S03-metaops/zip.t                                      (Wstat: 256 (exited 1) Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
t/spec/S03-metaops/infix.t                                    (Wstat: 256 (exited 1) Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
t/spec/S03-metaops/reduce.t                                   (Wstat: 256 (exited 1) Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
t/spec/S03-operators/equality.t                               (Wstat: 256 (exited 1) Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
t/spec/S03-metaops/hyper.rakudo.moar                          (Wstat: 256 (exited 1) Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
t/spec/S04-declarations/my-6e.rakudo.moar                     (Wstat: 0 Tests: 109 Failed: 0)
  TODO passed:   60
t/spec/S05-match/capturing-contexts.rakudo.moar               (Wstat: 512 (exited 2) Tests: 64 Failed: 2)
  Failed tests:  53-54
  Non-zero exit status: 2
t/spec/S05-modifier/exhaustive.t                              (Wstat: 1024 (exited 4) Tests: 80 Failed: 4)
  Failed tests:  2, 11, 13, 22
  Non-zero exit status: 4
  Parse errors: Bad plan.  You planned 104 tests but ran 80.
t/spec/S06-currying/misc.rakudo.moar                          (Wstat: 256 (exited 1) Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
t/spec/S06-currying/assuming-and-mmd.t                        (Wstat: 256 (exited 1) Tests: 11 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
t/spec/S06-currying/slurpy.rakudo.moar                        (Wstat: 65280 (exited 255) Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 32 tests but ran 0.
t/spec/S06-multi/by-trait.rakudo.moar                         (Wstat: 0 Tests: 13 Failed: 0)
  TODO passed:   12
t/spec/S06-currying/named.rakudo.moar                         (Wstat: 65280 (exited 255) Tests: 24 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 28 tests but ran 24.
t/spec/S06-currying/positional.rakudo.moar                    (Wstat: 65280 (exited 255) Tests: 55 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 166 tests but ran 55.
t/spec/S06-operator-overloading/infix.rakudo.moar             (Wstat: 256 (exited 1) Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
t/spec/S06-signature/arity.t                                  (Wstat: 65280 (exited 255) Tests: 54 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 56 tests but ran 54.
t/spec/S06-signature/introspection.rakudo.moar                (Wstat: 256 (exited 1) Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
t/spec/S09-typed-arrays/arrays.rakudo.moar                    (Wstat: 256 (exited 1) Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
t/spec/S12-enums/basic.rakudo.moar                            (Wstat: 256 (exited 1) Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
t/spec/S12-methods/syntax.rakudo.moar                         (Wstat: 65280 (exited 255) Tests: 10 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 15 tests but ran 10.
t/spec/S32-num/complex.t                                      (Wstat: 256 (exited 1) Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
Files=1350, Tests=110709, 193 wallclock secs (13.57 usr  1.71 sys + 1353.89 cusr 51.46 csys = 1420.63 CPU)
Result: FAIL
make: *** [Makefile:1197: m-spectest5] Error 1

@MasterDuke17
Copy link
Contributor

A regular make test passed in both NQP and Rakudo.

@zhuomingliang
Copy link
Member Author

A Rakudo spectest with NQP built on this branch:

Test Summary Report
-------------------
t/spec/6.c/APPENDICES/A04-experimental/01-misc.rakudo.moar    (Wstat: 0 Tests: 19 Failed: 0)
  TODO passed:   1
t/spec/6.c/S04-declarations/my-6c.rakudo.moar                 (Wstat: 0 Tests: 112 Failed: 0)
  TODO passed:   61
t/spec/S02-names-vars/signature.t                             (Wstat: 256 (exited 1) Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
t/spec/S02-types/pair.rakudo.moar                             (Wstat: 256 (exited 1) Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
t/spec/S02-types/num.rakudo.moar                              (Wstat: 256 (exited 1) Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
t/spec/S02-types/whatever.rakudo.moar                         (Wstat: 256 (exited 1) Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
t/spec/S03-metaops/cross.t                                    (Wstat: 256 (exited 1) Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
t/spec/S03-junctions/misc.t                                   (Wstat: 256 (exited 1) Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
t/spec/S03-metaops/not.rakudo.moar                            (Wstat: 256 (exited 1) Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
t/spec/S03-metaops/reverse.t                                  (Wstat: 256 (exited 1) Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
t/spec/S03-metaops/zip.t                                      (Wstat: 256 (exited 1) Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
t/spec/S03-metaops/infix.t                                    (Wstat: 256 (exited 1) Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
t/spec/S03-metaops/reduce.t                                   (Wstat: 256 (exited 1) Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
t/spec/S03-operators/equality.t                               (Wstat: 256 (exited 1) Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
t/spec/S03-metaops/hyper.rakudo.moar                          (Wstat: 256 (exited 1) Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
t/spec/S04-declarations/my-6e.rakudo.moar                     (Wstat: 0 Tests: 109 Failed: 0)
  TODO passed:   60
t/spec/S05-match/capturing-contexts.rakudo.moar               (Wstat: 512 (exited 2) Tests: 64 Failed: 2)
  Failed tests:  53-54
  Non-zero exit status: 2
t/spec/S05-modifier/exhaustive.t                              (Wstat: 1024 (exited 4) Tests: 80 Failed: 4)
  Failed tests:  2, 11, 13, 22
  Non-zero exit status: 4
  Parse errors: Bad plan.  You planned 104 tests but ran 80.
t/spec/S06-currying/misc.rakudo.moar                          (Wstat: 256 (exited 1) Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
t/spec/S06-currying/assuming-and-mmd.t                        (Wstat: 256 (exited 1) Tests: 11 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
t/spec/S06-currying/slurpy.rakudo.moar                        (Wstat: 65280 (exited 255) Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 32 tests but ran 0.
t/spec/S06-multi/by-trait.rakudo.moar                         (Wstat: 0 Tests: 13 Failed: 0)
  TODO passed:   12
t/spec/S06-currying/named.rakudo.moar                         (Wstat: 65280 (exited 255) Tests: 24 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 28 tests but ran 24.
t/spec/S06-currying/positional.rakudo.moar                    (Wstat: 65280 (exited 255) Tests: 55 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 166 tests but ran 55.
t/spec/S06-operator-overloading/infix.rakudo.moar             (Wstat: 256 (exited 1) Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
t/spec/S06-signature/arity.t                                  (Wstat: 65280 (exited 255) Tests: 54 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 56 tests but ran 54.
t/spec/S06-signature/introspection.rakudo.moar                (Wstat: 256 (exited 1) Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
t/spec/S09-typed-arrays/arrays.rakudo.moar                    (Wstat: 256 (exited 1) Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
t/spec/S12-enums/basic.rakudo.moar                            (Wstat: 256 (exited 1) Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
t/spec/S12-methods/syntax.rakudo.moar                         (Wstat: 65280 (exited 255) Tests: 10 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 15 tests but ran 10.
t/spec/S32-num/complex.t                                      (Wstat: 256 (exited 1) Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
Files=1350, Tests=110709, 193 wallclock secs (13.57 usr  1.71 sys + 1353.89 cusr 51.46 csys = 1420.63 CPU)
Result: FAIL
make: *** [Makefile:1197: m-spectest5] Error 1

Is these caused by this PR?

@zhuomingliang zhuomingliang changed the title Some code cleanup and re-order, reduces blib\Raku\Grammar.moarvm about 65KB Some code cleanup and re-order, reduces blib\Raku\Grammar.moarvm about 95KB Apr 25, 2025
@MasterDuke17
Copy link
Contributor

MasterDuke17 commented Apr 25, 2025 via email

@MasterDuke17
Copy link
Contributor

Yeah, this is what I get with main/main.

Test Summary Report
-------------------
t/spec/6.c/APPENDICES/A04-experimental/01-misc.rakudo.moar    (Wstat: 0 Tests: 19 Failed: 0)
  TODO passed:   1
t/spec/6.c/S04-declarations/my-6c.rakudo.moar                 (Wstat: 0 Tests: 112 Failed: 0)
  TODO passed:   61
t/spec/S04-declarations/my-6e.rakudo.moar                     (Wstat: 0 Tests: 109 Failed: 0)
  TODO passed:   60
t/spec/S06-multi/by-trait.rakudo.moar                         (Wstat: 0 Tests: 13 Failed: 0)
  TODO passed:   12
Files=1350, Tests=118798, 194 wallclock secs (13.50 usr  1.87 sys + 1353.65 cusr 52.39 csys = 1421.41 CPU)
Result: PASS

@zhuomingliang
Copy link
Member Author

Thanks, my computer is very slow and has some problem with compiling nqp and rakudo now, and also too slow to do make spectest, I will keep this PR until I find which change cause these regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants