Realized task with tests and javadocs. #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzuken
reviewed
May 23, 2018
|
|
||
| private void setUpField(int n) { | ||
| GameController gameController = new GameController(n); | ||
| field = new GridPane(); |
Collaborator
There was a problem hiding this comment.
лейауты бы тут совсем не помешали, окно зумится довольно некрасиво
| /** | ||
| * Class that controls game flow and creates buttons for user interaction. | ||
| */ | ||
| public class GameController { |
Collaborator
There was a problem hiding this comment.
этот класс бы стоило разбить, явно выделив работу с UI и работу с логикой игры. тогда и тесты можно было бы нормально писать
| /** | ||
| * Initializes buttons: set ups on click listeners. | ||
| */ | ||
| private void initButtons() { |
Collaborator
There was a problem hiding this comment.
большеват метод, из него можно смело несколько вспомогательных выделить
| public static void initJFX() { | ||
| Thread t = new Thread("JavaFX Init Thread") { | ||
| public void run() { | ||
| Application.launch(AsNonApp.class); |
Collaborator
There was a problem hiding this comment.
не нужно в тестах никакого UI создавать, особенно в модульных
Collaborator
|
7 баллов |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.