Update rook version from 1.12 to 1.13 #1210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This current rook version fails to take latest ci changes. This commit updates the rook version. Signed-off-by: yati1998 <ypadia@redhat.com>
yati1998
force-pushed
the
rook-version
branch
from
15b7605 to
5d32433
Compare
raghavendra-talur
approved these changes
Feb 19, 2024
Author
Shwetha-Acharya
approved these changes
Feb 20, 2024
Member
|
Thanks @yati1998! can you describe how did you test this? Did you start the envs/rook.yaml with this change? Did you start envs/regional-dr.yaml and run basic-test/run with this change? |
Author
I started the envs/rook.yaml with this change and see everything working fine, but didn't test it with regional-dr.yaml |
Member
|
Tried to test locally, so far starting regional dr failed because after we cleared |
Author
got it, I will check the failure and see what changes are required. |
yati1998
changed the title
Member
|
@yati1998 we need to understand better why new osd blocklist are created - so far we I will run more tests locally, we must have this change work on volume snapshot replication. |
Member
|
Next run timed out when waiting for the pool to become healthy. I run successful tests today with regional-dr-kubevirt.yaml and rook 1.12, so upgrading |
Member
|
Running with rook.yaml works fine - this does the same work we do in regional-dr Maybe the failures are related to overloading the laptop. From my experience we this |
Member
|
Did a successful run with regional-dr.yaml and run basic-test. I think we can Regardless we should understand why we see blocklist entries and why Tested on top of #1153 |
nirs
approved these changes
Feb 21, 2024
nirs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This current rook version fails to take latest ci changes. This commit updates the rook version.