Updating configs to use applicationset samples #2204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 30, 2025
abhijeet219
force-pushed
the
update-ramen-samples
branch
from
d79527d to
6c33582
Compare
Signed-off-by: Abhijeet Shakya <abhijeetshakya21@gmail.com>
abhijeet219
force-pushed
the
update-ramen-samples
branch
from
6c33582 to
02711df
Compare
rakeshgm
approved these changes
Jul 30, 2025
nirs
reviewed
Jul 30, 2025
Member
nirs
left a comment
nirs
left a comment
There was a problem hiding this comment.
We don't use these files now since we have e2e. I don't mind updating them but I'm not going to fix anything in this code if it breaks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes usage of subscriptions based application(deprecated) samples to applicationset, from OCM ramen samples.
Migration strategy:
Step 1: Update ramen repository to use ApplicationSets (this PR)
Step 2: Remove subscription samples (PR)