disapp: create namespace(s) on the secondary cluster #2335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asn1809
force-pushed
the
asn-ns-creation-onc2
branch
from
7be3831 to
e436eb0
Compare
asn1809
force-pushed
the
asn-ns-creation-onc2
branch
from
e436eb0 to
43cad1c
Compare
asn1809
force-pushed
the
asn-ns-creation-onc2
branch
from
43cad1c to
4e5d5bd
Compare
In the mw_util, CreateOrUpdateNamespaceManifest was not accepting labels as one of the argument and was always sending empty labels. Parameterizing, so that any consumers of it will be able to send the labels as well now. The existing callers are made to send empty labels so that they are not impacted. Signed-off-by: Annaraya Narasagond <annarayanarasagond@gmail.com>
asn1809
force-pushed
the
asn-ns-creation-onc2
branch
2 times, most recently
from
9288d5b to
1c5a7d9
Compare
asn1809
force-pushed
the
asn-ns-creation-onc2
branch
from
1c5a7d9 to
6c825c8
Compare
For discovered apps, both RBD and CephFS, currently user needs to create namespace on secondary cluster. This PR will get all the namespaces defined in the drpc.protectedNamespaces using ManagedClusterView and retain the labels and non scc annotations and create on other cluster using ManifestWork. Signed-off-by: Annaraya Narasagond <annarayanarasagond@gmail.com>
asn1809
force-pushed
the
asn-ns-creation-onc2
branch
from
6c825c8 to
9f46c14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the mw_util, CreateOrUpdateNamespaceManifest was not accepting labels
as one of the argument and was always sending empty labels. Parameterizing,
so that any consumers of it will be able to send the labels as well now. The
existing callers are made to send empty labels so that they are not impacted.
For discovered apps, both RBD and CephFS, currently user needs to
create namespace on secondary cluster. This PR will get all the namespaces
defined in the drpc.protectedNamespaces using ManagedClusterView and retain
the labels and non scc annotations and create on other cluster using ManifestWork.