-
Notifications
You must be signed in to change notification settings - Fork 67
Enhance install.md documentation #2341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
f08b751 to
0262c90
Compare
0262c90 to
62ec11a
Compare
Signed-off-by: Chris Blum <cblum@ibm.com> (cherry picked from commit 568d24e) Signed-off-by: rakeshgm <rakeshgm@redhat.com>
62ec11a to
5d580a4
Compare
5d580a4 to
ff20e94
Compare
ff20e94 to
59deab5
Compare
ShyamsundarR
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial set of comments
docs/install.md
Outdated
|
|
||
| **Supported versions:** | ||
|
|
||
| - Kubernetes 1.20 or higher |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make this 1.30 and above; 1.20 is quite old at present.
docs/install.md
Outdated
|
|
||
| **Requirements:** | ||
|
|
||
| - OCM hub cluster with `multicluster-engine` installed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about "multicluster-engine" installation.
We have a few addons that we require, as we install in drenv, and we should leverage that as an example here.
See:
ramen/test/addons/ocm-hub/start
Lines 19 to 28 in a5256ba
ADDONS = ( { "name": "application-manager", "version": BUNDLE_VERSION, }, { "name": "governance-policy-framework", "version": BUNDLE_VERSION, }, ) - https://github.com/stolostron/multicloud-operators-foundation.git/deploy/foundation/hub/overlays/ocm-controller?ref=main&timeout=300s - (for managed cluster)
ramen/test/addons/ocm-cluster/start
Lines 22 to 35 in a5256ba
ADDONS = ( { "name": "application-manager", "deployment": "application-manager", }, { "name": "governance-policy-framework", "deployment": "governance-policy-framework", }, { "name": "config-policy-controller", "deployment": "config-policy-controller", }, )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added all the add-ons list now but I have not added any explicit installation links for any
docs/install.md
Outdated
| #### Sync Mode (Metro DR) | ||
|
|
||
| Sync mode uses a dedicated external storage cluster that all managed clusters | ||
| connect to, enabling synchronous, real-time data replication. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this "enabling synchronous, real-time data replication.".
The use of an external shared storage is not the one providing sync replication, hence the latter part of the sentence is misleading.
We could add something like ", providing all clusters access to the same storage backend."
docs/install.md
Outdated
|
|
||
| #### Sync Mode (Metro DR) | ||
|
|
||
| Sync mode uses a dedicated external storage cluster that all managed clusters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drop "dedicated" the storage cluster can be of other forms as well.
docs/install.md
Outdated
|
|
||
| **Supported:** | ||
|
|
||
| - Any CSI-compatible storage that supports synchronous replication |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reword to "Any CSI-compatible storage that supports connecting to a shared external storage cluster"
docs/install.md
Outdated
| **Supported:** | ||
|
|
||
| - Any CSI-compatible storage that supports synchronous replication | ||
| - External storage clusters accessible from all managed clusters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace this line with, "CSI drivers support static provisioning for PVCs and have the ability to attach the same storage when a PV is transferred from one cluster to the other, when sharing the same storage backend" (or something along these lines, to indicate that we do PV transfers and the CSI drivers should allow static provisioning etc.)
docs/install.md
Outdated
|
|
||
| - Dedicated external storage cluster | ||
| - Storage provider installed that supports CSI and synchronous replication | ||
| - StorageClasses on managed clusters with the same `storageID` label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reference to a storageID label here is incomplete, i.e we need the entire label. Also the label is storageid (no caps at the end) as in code.
docs/install.md
Outdated
|
|
||
| **Supported:** | ||
|
|
||
| - Any CSI-compatible storage that supports VolumeReplication or VolSync |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace Volsync with VolumeSnapshots, as the storage CSI need not support Volsync, it only needs to support VolumeSnapshots.
Hmmm next line seems to state the same thing as well, so maybe we fold it into one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provide link to csi-addons spec repository for VolRep.
docs/install.md
Outdated
|
|
||
| #### Async Mode (Regional DR) | ||
|
|
||
| Async mode uses local storage in each managed cluster with asynchronous |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not need "local storage". I think this also needs to be massaged.
| - Low-latency network connectivity between managed clusters and the external | ||
| storage cluster | ||
|
|
||
| #### Async Mode (Regional DR) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(future) Overall we would need a doc on sync/async and what that means in the DR and ramen scope
ShyamsundarR
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done with comments.
docs/install.md
Outdated
| **Required:** | ||
|
|
||
| - Storage provider installed in each managed cluster that supports CSI and | ||
| volume replication |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
volrep or volsnapshot
docs/install.md
Outdated
|
|
||
| The following tools must be installed on your workstation: | ||
|
|
||
| - **kubectl** >= v1.21 - Kubernetes CLI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
push version to 1.30
|
|
||
| - kubectl > v1.21 | ||
| - kubectl version can be verfied using | ||
| ### Configuration Prerequisites |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once configure.md is posted, I think I will delete this section in this doc.
| - Missing dependencies - ensure OCM is properly installed | ||
|
|
||
| ### Rollback Installation | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a note to state that if configure, rollback configuration before rolling back the installation.
59deab5 to
0aefbcc
Compare
Signed-off-by: rakeshgm <rakeshgm@redhat.com>
0aefbcc to
d6faa71
Compare
Enhancement to PR #2332: refines and simplifies the installation documentation.
Changes:
This PR focuses only on install.md improvements.