CephFS relocation: stop listing PVCs by consistency group label #2375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ELENAGER
force-pushed
the
DFBUGS-4972
branch
2 times, most recently
from
7aa9de1 to
69d5c96
Compare
During the RunFinalSync of the CephFS relocation flow, we remove the consistency group label from the PVC and add a consistency group annotation for future uses. In the next reconciliation cycle, we try to list PVCs by that label, which fails because the label is no longer present. We can avoid this lookup entirely and just use the PVC we already have. Signed-off-by: Elena Gershkovich <elenage@il.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the RunFinalSync of the CephFS relocation flow, we remove the consistency group label from the PVC and add a consistency group annotation for future uses. In the next reconciliation cycle, we try to list PVCs by that label, which fails because the label is no longer present. We can avoid this lookup entirely and just use the PVC we already have.
Fixes: https://issues.redhat.com/browse/DFBUGS-4972