Add StorageAccessDetails to DRClusterConfig and Alerts on CIDR mismatch #2378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakeshgm
force-pushed
the
cidr-alerts
branch
5 times, most recently
from
cc3c314 to
afd743d
Compare
Add StorageAccessDetail type to DRClusterConfigStatus to store storage provisioner information along with associated CIDR blocks. The StorageAccessDetail struct contains: - StorageProvisioner: name of the storage provisioner - CIDRS: list of CIDR blocks that need network access Signed-off-by: rakeshgm <rakeshgm@redhat.com>
Add controller logic to populate StorageAccessDetails in DRClusterConfig status by extracting CIDRs from CSIAddonsNode resources. The implementation: - Lists NetworkFenceClientStatus entries from CSIAddonsNodes that match supported NetworkFenceClasses - Groups CIDRs by storage provisioner from NetworkFenceClass spec - Updates DRClusterConfig status with the collected StorageAccessDetails Also adds CSIAddonsNode CRD to test environment and updates tests. Signed-off-by: rakeshgm <rakeshgm@redhat.com>
Grant get and list permissions on CSIAddonsNode resources to the DRClusterConfig controller so it can read NetworkFenceClientStatus information needed to populate StorageAccessDetails. Signed-off-by: rakeshgm <rakeshgm@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds StorageAccessDetails to DRClusterConfig status to update
storage provisioner CIDRs extracted from CSIAddonsNode resources.
Changes
API Changes: Add StorageAccessDetail type to DRClusterConfigStatus
Controller Implementation: Populate StorageAccessDetails from CSIAddonsNodes
RBAC Updates: Add permissions for CSIAddonsNode resources
Metrics: create a new metrics which sets to true when there is a mismatch detected
when users update incorrect CIDRs on DRCluster.
Alert raise an alert on the hub cluster based on the metric value
Testing