refactor(user auth): Сonsolidate and enhance auth views, serializers, and validation #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored SignUpView and SignInView to better leverage DRF generic views and SimpleJWT patterns. - Simplified view logic by removing manual error handling and post overrides where applicable, relying on serializers and base view implementations. - Removed redundant imports. - Removed BaseCustomResponseMixin.
- Extract “magic” numbers and messages into top-level constants for clarity - Replace custom JSONField validator with nested `OtherFieldSerializer` that handles `age` and ISO 3166 country code validation - Refactor `SignInSerializer`: - Use `F()` expressions and `update_fields` to atomically bump `token_version` - Extract token blacklisting into `blacklist_other_tokens` with bulk_create - Convert `get_token` to `@classmethod`, adding `token_version` claim - Clean up `SignUpSerializer`: - Use nested `OtherFieldSerializer` for `other` JSON - Simplify `create()` logic and handle Django `ValidationError` correctly - Removed redundant imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor(user auth): Сonsolidate and enhance auth views, serializers, and validation
otherdata