Skip to content

Comments

Web samples#474

Draft
pusewicz wants to merge 4 commits intoRandyGaul:masterfrom
pusewicz:web-samples
Draft

Web samples#474
pusewicz wants to merge 4 commits intoRandyGaul:masterfrom
pusewicz:web-samples

Conversation

@pusewicz
Copy link
Contributor

No description provided.

@RandyGaul RandyGaul marked this pull request as ready for review February 13, 2026 23:10
@RandyGaul RandyGaul marked this pull request as draft February 13, 2026 23:11
Copy link
Owner

@RandyGaul RandyGaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmake step to generate shaders rather than checking them into git

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8803e81662

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

- HTTPS: topics/web.md
- Samples: samples.md
- Samples:
- samples/index.md

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep sample nav pages available in-tree

This nav block now references samples/*.md pages that are not present in a fresh checkout (there is no docs/samples/ content committed), so docs builds depend on running the web-sample generation pipeline first. That makes mkdocs build/serve fail for normal local docs workflows and any automation that expects source pages to exist before generation.

Useful? React with 👍 / 👎.

@bullno1
Copy link
Contributor

bullno1 commented Feb 14, 2026

cmake step to generate shaders rather than checking them into git

The problem is: Web build has cute-shaderc disabled.
And even when enabled, it's a wasm binary.

Without it, we can't generate headers.

It is possible to:

  • Build cute-shaderc from a different branch and pull it into this build with depend: or something.
  • Generate header in desktop build and pull them here

@RandyGaul
Copy link
Owner

Can't we just build shaderc on CI and then build the sample for web afterwards? Just do a normal native build of shaderc, generate the header, then do the web build

@RandyGaul
Copy link
Owner

By the way I don't think the sample building for web needs to be on every PR? I'm just a little worried that we're building way too much for CI? I don't want to run out of free service. Perhaps it can just be a manual trigger that we can run when a PR pops up to add samples (infrequent)

@bullno1
Copy link
Contributor

bullno1 commented Feb 14, 2026

Can't we just build shaderc on CI and then build the sample for web afterwards? Just do a normal native build of shaderc, generate the header, then do the web build

It's possible. I've had builds that passes files between jobs before.

By the way I don't think the sample building for web needs to be on every PR? I'm just a little worried that we're building way too much for CI? I don't want to run out of free service. Perhaps it can just be a manual trigger that we can run when a PR pops up to add samples (infrequent)

There should be a way to trigger a job based on location of changed files.
At work, we used to do that because certain tests take forever to run and that part of the project is infrequently updated.
It's gitlab but github should have something similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants