Conversation
RandyGaul
left a comment
There was a problem hiding this comment.
cmake step to generate shaders rather than checking them into git
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8803e81662
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - HTTPS: topics/web.md | ||
| - Samples: samples.md | ||
| - Samples: | ||
| - samples/index.md |
There was a problem hiding this comment.
Keep sample nav pages available in-tree
This nav block now references samples/*.md pages that are not present in a fresh checkout (there is no docs/samples/ content committed), so docs builds depend on running the web-sample generation pipeline first. That makes mkdocs build/serve fail for normal local docs workflows and any automation that expects source pages to exist before generation.
Useful? React with 👍 / 👎.
The problem is: Web build has cute-shaderc disabled. Without it, we can't generate headers. It is possible to:
|
|
Can't we just build shaderc on CI and then build the sample for web afterwards? Just do a normal native build of shaderc, generate the header, then do the web build |
|
By the way I don't think the sample building for web needs to be on every PR? I'm just a little worried that we're building way too much for CI? I don't want to run out of free service. Perhaps it can just be a manual trigger that we can run when a PR pops up to add samples (infrequent) |
It's possible. I've had builds that passes files between jobs before.
There should be a way to trigger a job based on location of changed files. |
No description provided.