Reduce memory requirements for steam app id completion #669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m appids in the completer The completer needs to use it's own copy of steam app ids which increases the RAM usage by about 150MB. Using a bespoke item model doesn't work, as altering the view of an ordered dictionary is a not efficient enough, causing the UI to lock up. For that reason, we generate a reduce list of completions based on the first three letters of the application's name offer only those. The completer is replaced when the the view is shown and destroyed when the view get hidden.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The completer needs to use it's own copy of steam app ids which increases the RAM usage by about 150MB. Using a bespoke item model doesn't work, as
altering the view of an ordered dictionary is a not efficient enough, causing the UI to lock up. For that reason, we generate a reduce list of
completions based on the first three letters of the application's name offer only those. The completer is replaced when the the view is shown
and destroyed when the view get hidden.