Improve performance and code quality across core modules#7
Merged
Rashed-alothman merged 1 commit intomainfrom Mar 4, 2026
Merged
Improve performance and code quality across core modules#7Rashed-alothman merged 1 commit intomainfrom
Rashed-alothman merged 1 commit intomainfrom
Conversation
Download engine (manager.py): - Parallelize chunk downloads with asyncio.gather + semaphore (8 concurrent) - Stream chunk data via iter_chunked with inline SHA256 (halves peak memory) - Add connection pooling: TCPConnector(limit=30, limit_per_host=10, dns_cache) - Replace blocking file I/O with aiofiles in async download loop CLI startup (cli.py): - Lazy Console proxy defers Rich import until first print - Move Rich traceback install into main() instead of module level Blocking calls & caching: - Fix psutil.cpu_percent(interval=1) → interval=None (non-blocking) - Parallelize network endpoint checks with asyncio.gather - Add mtime-based config caching (skip disk reads when file unchanged) Error handling: - Fix all 4 bare except: clauses (progress.py, p2p.py, error_handler.py) - Fix 2 swallowed exceptions (except: pass → logging.debug) - Fix race condition: duplicate speed sample pop(0) outside lock - Optimize cache eviction: heapq.nsmallest vs sorted() (O(n+k) vs O(n log n)) - Fix asyncio.iscoroutinefunction deprecation in error_handler.py Tests (47 passing): - Add test_config.py: loading, caching, corruption handling (5 tests) - Add test_manager.py: DownloadChunk, init, connection pooling (5 tests) - Add test_network.py: connection check, caching behavior (2 tests) - Add test_session.py: SessionManager init, update, lookup (4 tests) - Fix test_cli.py: replace timeout-prone tests with fast import check Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Download engine (manager.py):
CLI startup (cli.py):
Blocking calls & caching:
Error handling:
Tests (47 passing):