Instantiate tensors on correct devices #467
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vamb used to have the following pattern a lot of places:
```python
my_tensor = _torch.zeros(n)
if self.usecuda:
my_tensor.cuda()
```
This is wasteful, as the tensor is instantiated on CPU, then moved to GPU,
instead of creating it directly on the GPU.
In this commit, where possible, we instantiate on the correct device from
the beginning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vamb used to have the following pattern a lot of places:
This is wasteful, as the tensor is instantiated on CPU, then moved to GPU, instead of creating it directly on the GPU.
In this commit, where possible, we instantiate on the correct device from the beginning.
WARNING This is vibe coded, and part of me learning how to use an AI agent. I've reviewed the changes, but the agents should not be trusted. Hence, this must be tested before merging.