Skip to content

Conversation

@jhh8
Copy link
Member

@jhh8 jhh8 commented Feb 23, 2025

current way to kill something is a little more complicated than it should be

@ywgATustcbbs
Copy link
Contributor

Would be nice if it is

Die(attacker = null)

@jhh8
Copy link
Member Author

jhh8 commented Mar 16, 2025

Thats same as

attacker = null
Die(null)

@ywgATustcbbs
Copy link
Contributor

Thats same as

attacker = null Die(null)

yeah. But Die(hMarine.entindex()) is useful in some cases

@BenLubar
Copy link
Contributor

Would be nice if it is

Die(attacker = null)

I don't think we can do optional parameters in vscript binds

…hich would lead to recursion

in case someone uses Die in the hook
@ywgATustcbbs
Copy link
Contributor

Would be nice if it is
Die(attacker = null)

I don't think we can do optional parameters in vscript binds

In cpp:
void CASW_Inhabitable_NPC::Die(TYPE attacker = null){...}

I think this will work. At least it allows to insta kill a marine and giving the attacker info

@jhh8
Copy link
Member Author

jhh8 commented Mar 29, 2025

Use existing TakeDamage function for this

@BenLubar BenLubar merged commit 526c35c into reactivedrop_beta Apr 2, 2025
2 checks passed
@BenLubar BenLubar deleted the die-vscript-func branch April 2, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants