Dev to Main Sync

[joyguptaa]

Date: 18 March 2025

Developer Name: Joy Gupta

---

Issue Ticket Number

• Verify (Claimed by @joyguptaa) #50
• Fix: Add instruction to setup env in Readme #62
• Setup Backend & Site URL as Constants Based on Environment #66
• Setup Env Vars for Staging and Production Environments #57

PRs going in sync

• CI(GH#57): Add ENV variable to deployment workflow #58
• Feat : Register Verify Command #55
• feat: Add environment configuration #67
• Add instruction to setup .env file #63

Description

This PR contains

1. Verify Command
2. Creating enums for command names
3. Added new env variables
4. Improved function names

Documentation Updated?

• Yes
• No

Under Feature Flag

• Yes
• No

Database Changes

• Yes
• No

Breaking Changes

• Yes
• No

Development Tested?

• Yes
• No

Screenshots

Details

Description by Korbit AI

What change is being made?

Sync development branch with main by updating deployment workflow, documentation, core service structure, command constants, error handling utilities, and comprehensive tests across services, handlers, and routes.

Why are these changes being made?

Standardize command naming and routing, improve error handling and JSON responses, and align tests with the main service flow for reliability and maintainability. This includes refactoring base controllers, routing, and service entry points to use a unified pattern.

Is this description stale? Ask me to generate a new description by commenting /korbit-generate-pr-description

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch develop

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[iamitprakash]

how come line 34 and 35 has localhost value assigned here, did we forgot to remove @vikhyat187

[joyguptaa]

It's for the local environment.

[iamitprakash]

It's for the local environment.

then this is not supposed to be here

[joyguptaa]

But is there any specific reason? because we have been using environment variables for 3 types of environments i.e., development, staging & production

[joyguptaa]

PR Ref : #67

[graphite-app]

The mockDiscordSession struct is missing the GuildMemberNickname method which is required by the DiscordSessionWrapper interface. To ensure the mock fully implements the interface, please add this method to the struct implementation. This will prevent potential interface compliance issues during testing.

Suggested change

	type mockDiscordSession struct {
	*discordgo.Session
	capturedMessage *string
	}
	func (m *mockDiscordSession) WebhookMessageEdit(webhookID, token, messageID string, data *discordgo.WebhookEdit, options ...discordgo.RequestOption) (*discordgo.Message, error) {
	if m.capturedMessage != nil {
	*m.capturedMessage = *data.Content
	}
	type mockDiscordSession struct {
	*discordgo.Session
	capturedMessage *string
	}
	func (m *mockDiscordSession) WebhookMessageEdit(webhookID, token, messageID string, data *discordgo.WebhookEdit, options ...discordgo.RequestOption) (*discordgo.Message, error) {
	if m.capturedMessage != nil {
	*m.capturedMessage = *data.Content
	}
	return nil, nil
	}
	func (m *mockDiscordSession) GuildMemberNickname(guildID, userID, nick string) error {
	return nil
	}

Spotted by Diamond



Is this helpful? React 👍 or 👎 to let us know.

[graphite-app]

The mockMainTestDiscordSession struct doesn't correctly implement the DiscordSessionWrapper interface. The interface requires a Close() method, but the mock implements mockClose() instead. To properly satisfy the interface contract, rename the method from mockClose() to Close().

Suggested change

	type mockMainTestDiscordSession struct {
	*discordgo.Session
	}
	func (m *mockMainTestDiscordSession) WebhookMessageEdit(webhookID, token, messageID string, data *discordgo.WebhookEdit, options ...discordgo.RequestOption) (*discordgo.Message, error) {
	return nil, nil
	}
	func (m *mockMainTestDiscordSession) mockGuildMemberNickname(guildID, userID, nickname string, options ...discordgo.RequestOption) error {
	panic("GuildMemberNickname called")
	}
	func (m *mockMainTestDiscordSession) mockClose() error {
	return nil
	}
	type mockMainTestDiscordSession struct {
	*discordgo.Session
	}
	func (m *mockMainTestDiscordSession) WebhookMessageEdit(webhookID, token, messageID string, data *discordgo.WebhookEdit, options ...discordgo.RequestOption) (*discordgo.Message, error) {
	return nil, nil
	}
	func (m *mockMainTestDiscordSession) mockGuildMemberNickname(guildID, userID, nickname string, options ...discordgo.RequestOption) error {
	panic("GuildMemberNickname called")
	}
	func (m *mockMainTestDiscordSession) Close() error {
	return nil
	}

Spotted by Diamond



Is this helpful? React 👍 or 👎 to let us know.