Skip to content

Conversation

@MayankBansal12
Copy link
Member

@MayankBansal12 MayankBansal12 commented Jan 9, 2026

Date: 09-01-2026

Developer Name: @MayankBansal12


Issue Ticket Number

Description

  • replace my site urls with main and status site

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

demo

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 9, 2026

Deploying dashboard-rds with  Cloudflare Pages  Cloudflare Pages

Latest commit: 971d5fe
Status: ✅  Deploy successful!
Preview URL: https://830d61a1.dashboard-rds.pages.dev
Branch Preview URL: https://fix-replace-my-site.dashboard-rds.pages.dev

View logs

@coderabbitai
Copy link

coderabbitai bot commented Jan 9, 2026

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The pull request updates URLs across the codebase from the legacy domain structure (https://my.realdevsquad.com/) to new domain endpoints, including https://www.realdevsquad.com/ and https://status.realdevsquad.com/. Changes affect navigation dropdowns, test expectations, and mock user data.

Changes

Cohort / File(s) Summary
Dropdown Navigation Links
userLogin.js, __tests__/home/home.test.js
Updated DROPDOWN_OPTIONS URLs: Status → https://www.realdevsquad.com/status, Profile → https://www.realdevsquad.com/profile, Tasks → https://status.realdevsquad.com/tasks, Identity → https://www.realdevsquad.com/identity
Mock User Data
mock-data/users/mockdata.js, mock-data/tasks-card-date-time-end-date-self/index.js
Updated profileURL in user objects from https://my.realdevsquad.com/identity to https://www.realdevsquad.com/identity

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 URLs hopping to new homes so fine,
From my.realdevsquad to www.realdevsquad's line,
Status, Profile, Tasks all freshly aligned,
Mock data dancing, with identity redesigned!
One little rabbit says: "Change looks divine!" ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: replacing 'my site' URLs with migrated pages across the codebase.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The PR description directly relates to the changeset, describing the core objective to replace 'my site' URLs with main and status site URLs.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (4)
mock-data/tasks-card-date-time-end-date-self/index.js (1)

1-6: Avoid duplicated domain strings in multiple mock fixtures.

Same suggestion as the other mock update: derive profileURL from a shared base URL constant to keep mocks consistent as domains evolve.

mock-data/users/mockdata.js (1)

37-43: Centralize the web base URL to reduce maintenance burden in mock data.

The hardcoded URL https://www.realdevsquad.com/identity appears in multiple mock files and is duplicated elsewhere in the codebase. While the codebase uses window.API_BASE_URL for API endpoints, there's no corresponding constant for web/frontend URLs (e.g., RDS_WEB_BASE_URL). Centralizing this as a constant would prevent drift if the domain or path changes.

Note: profileURL pointing to /identity is intentional—both /profile and /identity exist as distinct pages in the navigation (see userLogin.js). However, the semantic mismatch between the field name and destination warrants a comment in the mock data to clarify that this is the identity page, not the profile page.

__tests__/home/home.test.js (1)

426-447: Status vs Tasks domain split has unclear product intent due to navbar inconsistency.

The test correctly reflects userLogin.js, but navbar.global.js hardcodes the tasks page (https://status.realdevsquad.com/tasks) labeled as "Status"—conflicting with userLogin.js which labels that same domain as "Tasks". This suggests either:

  • www.realdevsquad.com/status is unused/deprecated, or
  • The navbar is mislabeled and should point to the status page instead

To prevent future sync issues across userLogin.js and navbar.global.js, extract shared base URLs into a single constant file:

const RDS_WEB_BASE_URL = 'https://www.realdevsquad.com';
const RDS_STATUS_BASE_URL = 'https://status.realdevsquad.com';

const DROPDOWN_OPTIONS = [
  { name: 'Status', link: `${RDS_WEB_BASE_URL}/status` },
  { name: 'Tasks', link: `${RDS_STATUS_BASE_URL}/tasks` },
  // ...
];
userLogin.js (1)

1-24: Extract dropdown URLs to base constants for consistency and maintainability.

Hardcoded URLs in DROPDOWN_OPTIONS are scattered and duplicated in test files. Instead, define base constants and compose URLs using template literals—this matches the pattern already used for STATUS_BASE_URL elsewhere in the codebase and ensures test/mock alignment.

Proposed refactor
 const urlParam = new URLSearchParams(window.location.search);
 const isDevFlag = urlParam.get('dev') === 'true';
+const RDS_WEB_BASE_URL = 'https://www.realdevsquad.com';
+const RDS_STATUS_BASE_URL = 'https://status.realdevsquad.com';
 const DROPDOWN_OPTIONS = [
   {
     name: 'Home',
     link: 'https://dashboard.realdevsquad.com/',
   },
   {
     name: 'Status',
-    link: 'https://www.realdevsquad.com/status',
+    link: `${RDS_WEB_BASE_URL}/status`,
   },
   {
     name: 'Profile',
-    link: 'https://www.realdevsquad.com/profile',
+    link: `${RDS_WEB_BASE_URL}/profile`,
   },
   {
     name: 'Tasks',
-    link: 'https://status.realdevsquad.com/tasks',
+    link: `${RDS_STATUS_BASE_URL}/tasks`,
   },
   {
     name: 'Identity',
-    link: 'https://www.realdevsquad.com/identity',
+    link: `${RDS_WEB_BASE_URL}/identity`,
   },
 ];

Also update the duplicate DROPDOWN_OPTIONS in __tests__/home/home.test.js (lines 427-448) to use the same constants or import from a centralized location.

📜 Review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 78eb083 and c10aae2.

📒 Files selected for processing (4)
  • __tests__/home/home.test.js
  • mock-data/tasks-card-date-time-end-date-self/index.js
  • mock-data/users/mockdata.js
  • userLogin.js
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build-test (22.x)
  • GitHub Check: Cloudflare Pages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants