-
Notifications
You must be signed in to change notification settings - Fork 164
chore: replace my site to migrated pages #1034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Deploying dashboard-rds with
|
| Latest commit: |
971d5fe
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://830d61a1.dashboard-rds.pages.dev |
| Branch Preview URL: | https://fix-replace-my-site.dashboard-rds.pages.dev |
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe pull request updates URLs across the codebase from the legacy domain structure ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (4)
mock-data/tasks-card-date-time-end-date-self/index.js (1)
1-6: Avoid duplicated domain strings in multiple mock fixtures.Same suggestion as the other mock update: derive
profileURLfrom a shared base URL constant to keep mocks consistent as domains evolve.mock-data/users/mockdata.js (1)
37-43: Centralize the web base URL to reduce maintenance burden in mock data.The hardcoded URL
https://www.realdevsquad.com/identityappears in multiple mock files and is duplicated elsewhere in the codebase. While the codebase useswindow.API_BASE_URLfor API endpoints, there's no corresponding constant for web/frontend URLs (e.g.,RDS_WEB_BASE_URL). Centralizing this as a constant would prevent drift if the domain or path changes.Note:
profileURLpointing to/identityis intentional—both/profileand/identityexist as distinct pages in the navigation (seeuserLogin.js). However, the semantic mismatch between the field name and destination warrants a comment in the mock data to clarify that this is the identity page, not the profile page.__tests__/home/home.test.js (1)
426-447: Status vs Tasks domain split has unclear product intent due to navbar inconsistency.The test correctly reflects
userLogin.js, butnavbar.global.jshardcodes the tasks page (https://status.realdevsquad.com/tasks) labeled as "Status"—conflicting withuserLogin.jswhich labels that same domain as "Tasks". This suggests either:
www.realdevsquad.com/statusis unused/deprecated, or- The navbar is mislabeled and should point to the status page instead
To prevent future sync issues across
userLogin.jsandnavbar.global.js, extract shared base URLs into a single constant file:const RDS_WEB_BASE_URL = 'https://www.realdevsquad.com'; const RDS_STATUS_BASE_URL = 'https://status.realdevsquad.com'; const DROPDOWN_OPTIONS = [ { name: 'Status', link: `${RDS_WEB_BASE_URL}/status` }, { name: 'Tasks', link: `${RDS_STATUS_BASE_URL}/tasks` }, // ... ];userLogin.js (1)
1-24: Extract dropdown URLs to base constants for consistency and maintainability.Hardcoded URLs in
DROPDOWN_OPTIONSare scattered and duplicated in test files. Instead, define base constants and compose URLs using template literals—this matches the pattern already used forSTATUS_BASE_URLelsewhere in the codebase and ensures test/mock alignment.Proposed refactor
const urlParam = new URLSearchParams(window.location.search); const isDevFlag = urlParam.get('dev') === 'true'; +const RDS_WEB_BASE_URL = 'https://www.realdevsquad.com'; +const RDS_STATUS_BASE_URL = 'https://status.realdevsquad.com'; const DROPDOWN_OPTIONS = [ { name: 'Home', link: 'https://dashboard.realdevsquad.com/', }, { name: 'Status', - link: 'https://www.realdevsquad.com/status', + link: `${RDS_WEB_BASE_URL}/status`, }, { name: 'Profile', - link: 'https://www.realdevsquad.com/profile', + link: `${RDS_WEB_BASE_URL}/profile`, }, { name: 'Tasks', - link: 'https://status.realdevsquad.com/tasks', + link: `${RDS_STATUS_BASE_URL}/tasks`, }, { name: 'Identity', - link: 'https://www.realdevsquad.com/identity', + link: `${RDS_WEB_BASE_URL}/identity`, }, ];Also update the duplicate
DROPDOWN_OPTIONSin__tests__/home/home.test.js(lines 427-448) to use the same constants or import from a centralized location.
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (4)
__tests__/home/home.test.jsmock-data/tasks-card-date-time-end-date-self/index.jsmock-data/users/mockdata.jsuserLogin.js
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build-test (22.x)
- GitHub Check: Cloudflare Pages
Date: 09-01-2026
Developer Name: @MayankBansal12
Issue Ticket Number
Description
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
demo