generated from RealDevSquad/website-template
-
Notifications
You must be signed in to change notification settings - Fork 167
chore: Replace "COMPLETED" with "DONE" in filter dropdown and remove feature flag #1342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vaishalimaheshwari2000
wants to merge
16
commits into
RealDevSquad:develop
Choose a base branch
from
vaishalimaheshwari2000:chore/remove-feature-flag-DONE
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
51efcae
chore/remove-featurew-flag-DONE
vaishalimaheshwari2000 197e18d
change in task-status.tsx file , reintialize the COMPLETED value
vaishalimaheshwari2000 aa86469
revert back from COMPLETED to DONE
vaishalimaheshwari2000 1aa75c3
resolve test cases
vaishalimaheshwari2000 3552959
Merge branch 'develop' into chore/remove-feature-flag-DONE
vikasosmium 9d2feb5
resolve test cases
vaishalimaheshwari2000 599be82
Update TaskDropDown.tsx
vaishalimaheshwari2000 5b11c2b
Update TaskDropDown.tsx
vaishalimaheshwari2000 9bba4ac
Update TaskDropDown.tsx
vaishalimaheshwari2000 f29995a
Merge branch 'develop' into chore/remove-feature-flag-DONE
Achintya-Chatterjee a40997d
Merge branch 'chore/remove-feature-flag-DONE' of https://github.com/v…
vaishalimaheshwari2000 292efce
Merge branch 'chore/remove-feature-flag-DONE' of https://github.com/v…
vaishalimaheshwari2000 3f07b31
Merge branch 'Real-Dev-Squad:develop' into chore/remove-feature-flag-…
vaishalimaheshwari2000 ecde9ec
Update FilterDropdown.test.tsx
vaishalimaheshwari2000 ead8afd
Update FilterDropdown.test.tsx
vaishalimaheshwari2000 0817a45
Update FilterDropdown.test.tsx
vaishalimaheshwari2000 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -49,10 +49,7 @@ const FilterDropdown = ({ | |
| .filter( | ||
| (tab: Tab) => | ||
| !depreciatedTaskStatus.includes(tab) && | ||
| !( | ||
| (isDevMode && tab === 'COMPLETED') || | ||
| (!isDevMode && tab === 'DONE') | ||
| ) | ||
MayankBansal12 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| tab !== 'COMPLETED' | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We don't even need this check, we have a |
||
| ) | ||
| .map((tab) => ( | ||
| <button | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.