generated from RealDevSquad/website-template
-
Notifications
You must be signed in to change notification settings - Fork 167
feat: update Tabs component with count summary #598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kedar-hargude
wants to merge
13
commits into
RealDevSquad:develop
Choose a base branch
from
kedar-hargude:feat/status-tasks-tabs
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
3cd273c
fixed banner styling of task progress and standup
Pratiyushkumar e059bb8
Wrote test caes for standup Feature
Pratiyushkumar 62843f7
reverting changes
Pratiyushkumar 19b26a9
Fix : inconsistency in the width of task-tabs and task-cards
j24m 0e3b8f7
Fix : task-card responsive for tab view.
j24m 2c45347
Refactor
j24m 9b28d96
Refactor
j24m ca0e521
Refactor
j24m e0b62f1
feat: update unit tests
kedar-hargude 0683abb
feat: change tabs design and add count on feature flag
kedar-hargude 8a63ae5
feat: include ui tab name changes
kedar-hargude 2ac6d63
refactor: create variable name for colours
kedar-hargude 013651c
fix: conflict files
kedar-hargude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,51 @@ | ||
| $theme-grey: #d4d4d5; | ||
| $theme-grey-light: #f1f1f5; | ||
| $gray-shade-color: #808080; | ||
| $gray-shade-color2: #5c5b5b; | ||
| $theme-dark-grey: #a1a5b7; | ||
| $theme-pink: #e30062; | ||
|
|
||
| .tabButton { | ||
| border: none; | ||
| border-bottom: 1.8px solid $theme-grey; | ||
| font-size: 0.85rem; | ||
| font-weight: bold; | ||
| color: $gray-shade-color; | ||
| background: var(--toastify-color-light); | ||
| padding: 0.45rem 0.8rem; | ||
| border-radius: 0.2rem 0.2rem 0 0; | ||
| cursor: pointer; | ||
| } | ||
|
|
||
| .tabButton:hover { | ||
| color: $gray-shade-color2; | ||
| } | ||
|
|
||
| .tabButton:active { | ||
| background-color: $theme-grey-light; | ||
| } | ||
|
|
||
| .active { | ||
| color: var(--toastify-color-dark); | ||
| border: 1.8px solid $theme-grey; | ||
| border-bottom: none; | ||
| background: var(--toastify-color-light); | ||
| } | ||
|
|
||
| .featureFlagTabButton { | ||
| background: white; | ||
| border: none; | ||
| padding: 12px 8px 8px; | ||
| font-size: 0.8em; | ||
| border-radius: 5px 5px 0 0; | ||
| border-bottom: 1px solid $theme-grey; | ||
| border: none; | ||
| cursor: pointer; | ||
| color: $theme-dark-grey; | ||
| } | ||
|
|
||
| .active { | ||
| .featureFlagActiveTab { | ||
| font-weight: bold; | ||
| border: 1px solid $theme-grey; | ||
| border-bottom: none; | ||
| background: white; | ||
| border: none; | ||
| border-bottom: 3px solid $theme-pink; | ||
| color: black; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you check whether em suits better or rem here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked it for all dimensions. There is no visible change for such a short value.