-
Notifications
You must be signed in to change notification settings - Fork 153
chore: remove dev flag from profile page #1114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe PR removes the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
app/controllers/profile.js (1)
73-73: Remove the dev flag from the API URL.Line 73 still includes
&dev=truein the API call URL, which is inconsistent with the PR objective to remove the dev flag from the profile page.🔎 Proposed fix
- const response = await fetch( - `${BASE_URL}/users/${this.userId}?profile=true&dev=true`, - { + const response = await fetch( + `${BASE_URL}/users/${this.userId}?profile=true`, + {
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (3)
app/controllers/profile.jsapp/routes/profile.jstests/unit/routes/profile-test.js
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build (18.x)
- GitHub Check: Cloudflare Pages
🔇 Additional comments (2)
app/controllers/profile.js (1)
12-12: LGTM: Router service removal is correct.The removal of the router service injection and
isDevgetter aligns with the PR objective to remove the dev flag from the profile page.app/routes/profile.js (1)
13-13: LGTM: Router service removal is correct.The removal of the router service injection aligns with the profile route not requiring a dev flag check in
beforeModel. Unlike other dev-exclusive routes (new-signup, login, notifications, mobile, live, identity, discord, applications), the profile route is not restricted to dev-only access. Thedevquery parameter is used for UI context and backend API calls, not for route-level access control.
9429db3 to
5cc31e0
Compare
Date: 01-01-2026
Developer Name: @MayankBansal12
Issue Ticket Number:-
/profilepage #1124Description:
Is Under Feature Flag
Database changes
Breaking changes (If your feature is breaking/missing something please mention pending tickets)
Is Development Tested?
Tested in staging?
Add relevant Screenshot below ( e.g test coverage etc. )
screencast
demo-profile.mp4