Skip to content

Conversation

@MayankBansal12
Copy link
Member

@MayankBansal12 MayankBansal12 commented Jan 1, 2026

Date: 01-01-2026

Developer Name: @MayankBansal12


Issue Ticket Number:-

Description:

  • Removes dev flag from profile page
  • Updates test for profile route and controller

Is Under Feature Flag

  • Yes
  • No

Database changes

  • Yes
  • No

Breaking changes (If your feature is breaking/missing something please mention pending tickets)

  • Yes
  • No

Is Development Tested?

  • Yes
  • No

Tested in staging?

  • Yes
  • No

Add relevant Screenshot below ( e.g test coverage etc. )

screencast
demo-profile.mp4

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 1, 2026

Deploying www-rds with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5cc31e0
Status:🚫  Build failed.

View logs

@coderabbitai
Copy link

coderabbitai bot commented Jan 1, 2026

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The PR removes the router service injection from both ProfileController and ProfileRoute, eliminates the isDev getter that checked dev query parameters, removes the beforeModel navigation guard that redirected based on the dev parameter, and updates the test suite to remove related stubs and assertion tests.

Changes

Cohort / File(s) Summary
Controller & Route Service Removal
app/controllers/profile.js, app/routes/profile.js
Removed @service router injection and the isDev getter from ProfileController. Removed router service and the beforeModel guard that redirected to /page-not-found unless queryParams.dev === 'true'.
Test Suite Updates
tests/unit/routes/profile-test.js
Removed route.transitionTo stubbing setup/teardown, removed two tests validating dev query parameter redirect behavior, and introduced a minimal test asserting the profile route exists.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A dev flag once guarded the gate,
But simplicity rules of late,
Routes cleaned up with a mighty swipe,
Tests refined to the proper type,
Now ProfileController hops more light!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: removing the dev flag from the profile page across controller, route, and tests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The PR description directly addresses the changeset by explicitly stating the removal of the dev flag from the profile page and updates to associated tests, matching the code changes.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
app/controllers/profile.js (1)

73-73: Remove the dev flag from the API URL.

Line 73 still includes &dev=true in the API call URL, which is inconsistent with the PR objective to remove the dev flag from the profile page.

🔎 Proposed fix
-      const response = await fetch(
-        `${BASE_URL}/users/${this.userId}?profile=true&dev=true`,
-        {
+      const response = await fetch(
+        `${BASE_URL}/users/${this.userId}?profile=true`,
+        {
📜 Review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c013f54 and 60cc86f.

📒 Files selected for processing (3)
  • app/controllers/profile.js
  • app/routes/profile.js
  • tests/unit/routes/profile-test.js
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build (18.x)
  • GitHub Check: Cloudflare Pages
🔇 Additional comments (2)
app/controllers/profile.js (1)

12-12: LGTM: Router service removal is correct.

The removal of the router service injection and isDev getter aligns with the PR objective to remove the dev flag from the profile page.

app/routes/profile.js (1)

13-13: LGTM: Router service removal is correct.

The removal of the router service injection aligns with the profile route not requiring a dev flag check in beforeModel. Unlike other dev-exclusive routes (new-signup, login, notifications, mobile, live, identity, discord, applications), the profile route is not restricted to dev-only access. The dev query parameter is used for UI context and backend API calls, not for route-level access control.

@MayankBansal12 MayankBansal12 self-assigned this Jan 1, 2026
@MayankBansal12 MayankBansal12 force-pushed the remove/profile-dev-flag branch from 9429db3 to 5cc31e0 Compare January 6, 2026 11:12
@iamitprakash iamitprakash merged commit 0e53da0 into develop Jan 6, 2026
3 of 4 checks passed
@iamitprakash iamitprakash deleted the remove/profile-dev-flag branch January 6, 2026 17:46
@MayankBansal12 MayankBansal12 mentioned this pull request Jan 7, 2026
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants