Skip to content

Fix #46 - Added columnNumber to uniquely identify the issue #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix #46 - Added columnNumber to uniquely identify the issue #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b963908
Add optional "columnNumber" property. Append columnNumber to filename…
ebhsgit Jan 25, 2021
bdae09a
Added ? to make columnNumber optional
ebhsgit Jan 25, 2021
0dd2251
Append lineNumber first
ebhsgit Jan 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/android/uk/co/reallysmall/cordova/plugin/firebase/crashlytics/LogErrorHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,15 @@ public JavascriptException(String message, StackTraceLine[] stackTraceLines) {
super(message);
StackTraceElement[] stackTrace = new StackTraceElement[stackTraceLines.length];
for(int i = 0; i < stackTraceLines.length; i++) {
String filename = stackTraceLines[i].fileName;
if(stackTraceLines[i].columnNumber > 0) {
filename = filename + ":" + stackTraceLines[i].lineNumber + ":" + stackTraceLines[i].columnNumber;
}

stackTrace[i] = new StackTraceElement(
stackTraceLines[i].className,
stackTraceLines[i].functionName,
stackTraceLines[i].fileName,
filename,
stackTraceLines[i].lineNumber
);
}
Expand All @@ -72,6 +77,7 @@ private static class StackTraceLine {
public String functionName;
public String fileName;
public int lineNumber;
public int columnNumber;

private StackTraceLine() {
}
Expand All @@ -83,6 +89,7 @@ public static StackTraceLine fromJSONObject(JSONObject json) throws JSONExceptio
sl.functionName = json.optString("functionName", "<<undefined>>");
sl.fileName = json.getString("fileName");
sl.lineNumber = json.getInt("lineNumber");
sl.columnNumber = json.optInt("columnNumber", -1);

return sl;
}
Expand Down
1 change: 1 addition & 0 deletions types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ declare namespace FirebaseCrashlytics {
functionName: string;
fileName: string;
lineNumber: number;
columnNumber?: number;
}
}